Uploaded image for project: 'JBRULES'
  1. JBRULES
  2. JBRULES-2727

NullPointerException due to abstract Spring beans in KnowledgeSessionDefinitionParser

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Blocker
    • 5.2.0.M1
    • 5.1.1.FINAL
    • None
    • Hide

      see description

      Show
      see description
    • Low

    Description

      This bug is located in the drools-spring component in class org.drools.container.spring.namespace.KnowledgeSessionDefinitionParser.java

      The class compares each Spring bean with a non NullPointer safe equals call.

      // find any kagent's for the current kbase and assign
        for ( String beanName : parserContext.getRegistry().getBeanDefinitionNames() ) {
        	BeanDefinition def = parserContext.getRegistry().getBeanDefinition(beanName); // is null if the Spring bean is abstract
        	if ( def.getBeanClassName().equals( KnowledgeAgentBeanFactory.class.getName() ) ) {        	// NullPointerException comes here due to the abstract bean that does not have a bean definition	        		
        		 PropertyValue pvalue = def.getPropertyValues().getPropertyValue( "kbase" );
        		 RuntimeBeanReference tbf = ( RuntimeBeanReference ) pvalue.getValue();        		 
        		if ( kbase.equals( tbf.getBeanName() ) ) {
        			factory.addPropertyValue( "knowledgeAgent", new RuntimeBeanReference( beanName ) );
        		}
        	}       	
        }

      We use abstract beans in our Spring project and it seems that an abstract bean does not have a BeanDefinition

      <bean id="i18NServiceConfig" abstract="true">
	<property name="xxx">
		<ref local="yyy" />
	</property>
</bean>

<bean class="de.corag.bpm.cone.service.i18n.I18NServiceImpl" parent="i18NServiceConfig">
            <property name="messageDao"><ref bean="messageDao"/></property>
</bean>

      if you change the equals statement like this no NullPointerException would be thrown

      // find any kagent's for the current kbase and assign
        for ( String beanName : parserContext.getRegistry().getBeanDefinitionNames() ) {
        	BeanDefinition def = parserContext.getRegistry().getBeanDefinition(beanName);
        	if ( KnowledgeAgentBeanFactory.class.getName().equals( def.getBeanClassName() ) ) {        	// NullPointerException is avoided in this statement        		
        		 PropertyValue pvalue = def.getPropertyValues().getPropertyValue( "kbase" );
        		 RuntimeBeanReference tbf = ( RuntimeBeanReference ) pvalue.getValue();        		 
        		if ( kbase.equals( tbf.getBeanName() ) ) {
        			factory.addPropertyValue( "knowledgeAgent", new RuntimeBeanReference( beanName ) );
        		}
        	}       	
        }

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem that impairs or prevents the functions of the product. JBRULES-2868 NullPointerException in KnowledgeSessionDefinitionParser

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Bug - A problem that impairs or prevents the functions of the product. JBRULES-2689 [drools-spring] KnowledgeSessionDefinitionParser generates nullpointerexception on parsing spring xml file due to missing class attribute on bean

          • Minor - To be worked after urgent, high, and medium priorities are resolved. This term is chosen when the severity of the issue is low, or the complexity or effort to correct it may be higher, relatively speaking. For low priority issues, known workarounds exist or are not needed due to the trivial effort needed to address the issue.
          • Closed

          Patch - An improvement or enhancement to an existing feature or task. Includes patches submitted by community commiters. JBPM-3024 JBPM5/Drools, Spring integration and NullPointer - could a commiter apply a simple patch already?

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Activity

            People

              kverlaen@redhat.com Kris Verlaenen
              silvio303 Silvio Wangler (Inactive)
              Archiver:
              rhn-support-ceverson Clark Everson

              Dates

                Created:
                Updated:
                Resolved:
                Archived:

                Time Tracking

                  Estimated:
                  Original Estimate - 1 hour
                  1h
                  Remaining:
                  Remaining Estimate - 1 hour
                  1h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified

                  PagerDuty