Stunner - failing tests

Hi romartin@redhat.com xiezhang@redhat.com tdolphin-1

I'll write the summary of current findings to have a common place for tracking this:

It seems like we are having two "issues" of different nature:

1) It was reported that some PRs are raising this error:

https://rhba-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/KIE/job/master/job/pullrequest/job/kie-wb-common-pullrequests/1618/

If you look inside:

some of the failing tests have "weird" failures like this one here:

https://rhba-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/KIE/job/master/job/pullrequest/job/kie-wb-common-pullrequests/1618/testReport/junit/org.kie.workbench.common.stunner.bpmn.backend.service.diagram.marshalling.tasks/NoneTaskTest/testUnmarshallSubprocessLevelTaskOneIncomeEmptyProperties_0_/

java.lang.ClassCastException: Cannot cast org.kie.workbench.common.stunner.bpmn.definition.UserTask to org.kie.workbench.common.stunner.bpmn.definition.NoneTask
at java.lang.Class.cast(Class.java:3369)
at org.kie.workbench.common.stunner.bpmn.backend.service.diagram.marshalling.tasks.Task.getTaskNodeById(Task.java:213)
at org.kie.workbench.common.stunner.bpmn.backend.service.diagram.marshalling.tasks.NoneTaskTest.testUnmarshallSubprocessLevelTaskOneIncomeEmptyProperties(NoneTaskTest.java:153)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

And errors like:

org.kie.workbench.common.stunner.bpmn.backend.service.diagram.BPMNDiagramMarshallerTest.testUnmarshallMagnetsInLane

Failing for the past 4 builds (Since Unstable#1615 )
Took 31 ms.
Stacktrace
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertNotNull(Assert.java:712)

On the other hand, we have many PRs, and even Stunner PRs, that have passed the tests for both the "normal build" and the "full downstream build" with no problems.

2) OutOfMemory error

Additionally or related with the above errors we have an OutOfMemory when running the stunner kie-wb-common-stunner-bpmn-backend tests. This also is apparently not happening in all PRs. But can be reproduced locally more easy.

[ERROR] Errors:
[ERROR] UserTaskTest.testMarshallSubprocessLevelTaskFilledProperties[0] » OutOfMemory ...
[ERROR] UserTaskTest.testMarshallSubprocessLevelTaskTwoIncomesFilledProperties:1126->Task.checkTaskMarshalling:222->BPMNDiagramMarshallerBase.unmarshall:387 » OutOfMemory
[INFO]
[ERROR] Tests run: 1641, Failures: 0, Errors: 2, Skipped: 24

For this last error I could see that the basically the org.apache.maven.surefire.booter.ForkedBooter process launched for executing the maven-sure-fire plugin is running out of memory.

A quick fix, and probably the fix is to increase the memory settings for the maven-surefire-plugin. The memory settings for this plugin are basically in the link below. Note that current configuration is 1024m for the JVM dedicated to run the tests. It's expected that this memory should be good enough for running all the tests, but it could be the case that the JVM just runs out of memory.

https://github.com/kiegroup/droolsjbpm-build-bootstrap/blob/3c2746037379630f4c06401f7605e9c24dd7998c/pom.xml#L774