Uploaded image for project: 'JBoss Enterprise Application Platform 4 and 5'
  1. JBoss Enterprise Application Platform 4 and 5
  2. JBPAPP-9914

Potential performance problem - debug log messages in HornetQXAResourceWrapper

    XMLWordPrintable

Details

    • Low
    • Not Required

    Description

      There is a potential performance problem in class org.hornetq.jms.server.recovery.HornetQXAResourceWrapper. There are debug log messages in commit, rollback, etc. without any check if debug log level is enabled. Messages are represented as concatenation of several strings.

      Each debug log message should be encapsulated by check if debug logging level is enabled. Especially when method uses string concatenation in message content.

      ...
      XAResource xaResource = getDelegate(true);
      HornetQXAResourceWrapper.log.debug("Commit " + xaResource + " xid " + " onePhase=" + onePhase);
      try {
      ...
      

      Attachments

        Activity

          People

            csuconic@redhat.com Clebert Suconic
            pslavice@redhat.com Pavel Slavicek
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: