Uploaded image for project: 'JBoss Logging'
  1. JBoss Logging
  2. JBLOGGING-52

Use of system property for proxy generation setting is too inflexible

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Major Major
    • None
    • 3.0.0.Beta4-jboss-logging
    • jboss-logging-spi
    • None
    • Workaround Exists
    • Hide

      Use static blocks to set the system property.

      Show
      Use static blocks to set the system property.

      JBoss Logging uses a system property to configure whether or not proxies are generated for type-safe loggers. This approach is very inflexible.

      The main issue is that the value of this system property is being cached too aggressively. In CDI extensions, we are forced to use a static code block to set the property so it is assigned early enough that JBoss Logging caches the correct value. However, with multiple extensions loading in a non-deterministic order, we end up having to put this static block in multiple places. [1]

      We need a better way to apply this setting. Perhaps a static method on a configuration API to assign the value before any logging takes place.

      [1] https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/seam/solder/log/LoggerExtension.java
      https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/seam/servlet/ServletExtension.java

              jperkins-rhn James Perkins
              dan.j.allen Dan Allen (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: