Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-8360

Manage Keys Dialog: new key is not added to the ssh-prefs if a key-file with the same name already exists

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Obsolete
    • Icon: Minor Minor
    • 3.3.x
    • 3.2.0.Final
    • deltacloud
    • None
    • Hide

      make sure you have a key-file in your ~/.ssh/ directory with the name of the key (ex. key.pem) we will create in the next step:

      1) Choose "Manage Keys" in the context menu of your cloud
      2) Create a new key (ex. key)
      3) make sure "Save key in folder" is checked and path is set to ~/.ssh/
      4) delete key
      5) hit cancel when the wizard asks you if the key shall be delete from the local key store
      6) (eventually: check that the key (ex. key.pem) still exists in ~/.ssh)
      7) (eventually: check that the key is not listed in the ssh-preferences - Preferences->General->Network Connections->SSH)

      Now create a new key with the same name:
      1) Choose "Manage Keys" in the context menu of your cloud
      2) Hit "New" and create a new key with the same name (ex. key)
      3) You get informed that there was a problem while the key was created (see screenshot).

      Result:
      The key was not added to the ssh-prefs (Preferences->General->Network Connections->SSH)

      Show
      make sure you have a key-file in your ~/.ssh/ directory with the name of the key (ex. key.pem) we will create in the next step: 1) Choose "Manage Keys" in the context menu of your cloud 2) Create a new key (ex. key) 3) make sure "Save key in folder" is checked and path is set to ~/.ssh/ 4) delete key 5) hit cancel when the wizard asks you if the key shall be delete from the local key store 6) (eventually: check that the key (ex. key.pem) still exists in ~/.ssh) 7) (eventually: check that the key is not listed in the ssh-preferences - Preferences->General->Network Connections->SSH) Now create a new key with the same name: 1) Choose "Manage Keys" in the context menu of your cloud 2) Hit "New" and create a new key with the same name (ex. key) 3) You get informed that there was a problem while the key was created (see screenshot). Result: The key was not added to the ssh-prefs (Preferences->General->Network Connections->SSH)

      The current behavior is correct IMHO. There's no sense to add a key to the ssh-prefs if the key file is not present on disk.
      What's not brilliant here is that the user might think that the key was not created since he gets an error.
      What we could think of is to:

      • warn instead of displaying an error
      • OR offer a filename-dialog (allows to provide a valid filename).

              adietish@redhat.com André Dietisheim
              adietish@redhat.com André Dietisheim
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: