Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-25126

Server adapter editor, -wizard: validate debug-key, debug-port-key fields

XMLWordPrintable

    • devex #139 October 2017
    • 4

      Currently there's no validation (debug port is only required to be a numerical value, keys are free of any constraint) of the keys and values if they're provided. We should validate them.

            [JBIDE-25126] Server adapter editor, -wizard: validate debug-key, debug-port-key fields

            Josef Kopriva added a comment -

            Closing. Validation is working.

            Verified in:
            Red Hat JBoss Developer Studio
            Version: 11.1.0.GA
            Build id: GA-v20171026-1022-B1486
            Build date: 20171026-1022

            Josef Kopriva added a comment - Closing. Validation is working. Verified in: Red Hat JBoss Developer Studio Version: 11.1.0.GA Build id: GA-v20171026-1022-B1486 Build date: 20171026-1022

            André Dietisheim added a comment -

            this was fixed with the PR for JBIDE-25108

            André Dietisheim added a comment - this was fixed with the PR for JBIDE-25108

            André Dietisheim added a comment -

            This is included in the PR for JBIDE-25108

            André Dietisheim added a comment - This is included in the PR for JBIDE-25108

            André Dietisheim added a comment -

            The rules are printed out by the OpenShift REST API if you post invalid values:

            start with alphabetic character or '_', followed by a string of alphanumeric characters or '_' (e.g. 'my_name', or 'MY_NAME', or 'MyName', regex used for validation is '[A-Za-z_][A-Za-z0-9_]*'

            I implemented those rules when trying to solve JBIDE-25108: https://github.com/jbosstools/jbosstools-openshift/pull/1575/files#diff-bd1eb4f175d69710a67c665ebafe96ddR20

            André Dietisheim added a comment - The rules are printed out by the OpenShift REST API if you post invalid values: start with alphabetic character or '_' , followed by a string of alphanumeric characters or '_' (e.g. 'my_name' , or 'MY_NAME' , or 'MyName' , regex used for validation is '[A-Za-z_][A-Za-z0-9_]*' I implemented those rules when trying to solve JBIDE-25108 : https://github.com/jbosstools/jbosstools-openshift/pull/1575/files#diff-bd1eb4f175d69710a67c665ebafe96ddR20

              adietish@redhat.com André Dietisheim
              adietish@redhat.com André Dietisheim
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: