Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-24884

Log an error if detected cdk registry is wrong

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 4.5.1.AM1
    • Fix Version/s: 4.5.1.AM1
    • Component/s: cdk, openshift
    • Labels:
      None

      Description

      This is a followup of JBIDE-24783.
      When minishift openshift registry is unable to return a valid registry, the tooling should log an error. JBIDE-24783 was supposed to add this thing (along with removing the default value), but I was not able to trigger the error.

      The workflow is:
      Once cdk is started in eclipse, the cdk tooling will create the openshift connection and run minishift openshift registry to figure out which registry to use. But in my testing even if this returns "bla bla", the tooling will happily accept it.

      To test this, you can use a simple minishift wrapper such as this:

      #!/bin/bash
      
      case $* in
      "openshift registry")
      	echo bla bla
      	exit 1
      	;;
      *)
      	/Users/rasp/jbossqa/cdk/cdk-3.1.0/minishift $*
      esac
      

      You can also remove the "exit 1" to check what happens with zero exit code.

      In my opinion any of these should trigger an error:
      a) minishift openshift registry finishes with a non-zero code
      b) the returned string is not a valid url

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  rob.stryker Rob Stryker
                  Reporter:
                  mmalina Martin Malina
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: