-
Sub-task
-
Resolution: Done
-
Blocker
-
None
For JBIDE 4.4.4.Final [Hibernate]: Ensure all commits pushed to master have either been made in jbosstools-4.4.x, or are intentionally excluded from jbosstools-4.4.x.
Below are listed all commits made to master that have not been found in jbosstools-4.4.x. It is possible these commits do exist in jbosstools-4.4.x, but the patches are not identical. It is also possible that the commits made in master are not relevant to jbosstools-4.4.x or should not be applied.
If there are no commits listed below, please close (do not resolve) this issue.
Otherwise:
1) Click on each link below.
2) Evaluate whether the given commit should be in jbosstools-4.4.x
3) If it should be in jbosstools-4.4.x, please find out why it is not in jbosstools-4.4.x. You may need to browse jbosstools-4.4.x's commit log to find a commit that should match.
4) If you cannot find a matching commit, and it should be committed to jbosstools-4.4.x, please cherry-pick that commit to jbosstools-4.4.x or otherwise merge it in.
5) In comments, please indicate any suspicious commits (ie, commits not related to simple version changes), whether it exists in jbosstools-4.4.x, whether you have successfully merged it in now, or whether it is not intended to be committed to jbosstools-4.4.x or is inappropriate for jbosstools-4.4.x.
6) When all complete, please close (do not resolve) this issue.
Folder: jbosstools-hibernate at https://github.com/jbosstools/jbosstools-hibernate
Searching for commits present in master and missing from jbosstools-4.4.x
Commit hash "1e9f24" is the last common ancestor of master and jbosstools-4.4.x
1e9f24 is 15 commits ago in branch jbosstools-4.4.x
1e9f24 is 37 commits ago in branch master
Commits missing from jbosstools-4.4.x that are in master:
- missing:
JBIDE-24281-Update-hibernate-tools-dependency-of-org.jboss.tools.hibernate.runtime.v_5_2-to-version-5.1.3.Final https://github.com/jbosstools/jbosstools-hibernate/commit/b9c7e21897e5e4feac79363f226b05460229fa5c- possible match: https://github.com/jbosstools/jbosstools-hibernate/commit/5236edb4019e80cd1a78d4f9205ed584ddd5e882
- Inspect the difference between the two patches: http://sprunge.us/fLdb
- possible match: https://github.com/jbosstools/jbosstools-hibernate/commit/5236edb4019e80cd1a78d4f9205ed584ddd5e882
- missing:
JBIDE-24278-Update-hibernate-tools-dependency-of-org.jboss.tools.hibernate.runtime.v_5_1-to-version-5.1.4.Final https://github.com/jbosstools/jbosstools-hibernate/commit/ebf75adbb9165e8b425bf43e84dfaf9c93450b83
The following is missing a small change to build.properties which seems unnecessary, but needs Koen's +1
- missing:
JBIDE-24272-Update-hibernate-tools-dependency-of-org.jboss.tools.hibernate.runtime.v_5_0-to-version-5.0.6.Final https://github.com/jbosstools/jbosstools-hibernate/commit/31ca9e55be01e830162facb911faf271d834e0ab- possible match: https://github.com/jbosstools/jbosstools-hibernate/commit/788692c59483b86849f85bc5cf4e50fdbd799179
- Inspect the difference between the two patches: http://sprunge.us/UBDc
- possible match: https://github.com/jbosstools/jbosstools-hibernate/commit/788692c59483b86849f85bc5cf4e50fdbd799179
Everything below here is for master only, so doesn't need to be reviewed anymore.
- missing:
JBIDE-24119-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ISessionFactory-Improve-the-test-for-ISessionFactory-getCollectionMetadata-String https://github.com/jbosstools/jbosstools-hibernate/commit/dbdcf295fc681b32b97b91d739a31a371f55f0bd - missing:
JBIDE-24119-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ISessionFactory-Improve-the-test-for-ISessionFactory-getClassMetadata-String https://github.com/jbosstools/jbosstools-hibernate/commit/7fead055d540b1399af48f6351113f6f6e0e14c9 - missing:
JBIDE-24119-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ISessionFactory-Improve-the-test-for-ISessionFactory-getClassMetadata-Class https://github.com/jbosstools/jbosstools-hibernate/commit/68528444e9796e878e01d5bd555737a1a8f2f485 - missing:
JBIDE-24119-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ISessionFactory-Add-a-test-for-ISessionFactory-openSession https://github.com/jbosstools/jbosstools-hibernate/commit/224624316e970f2ffc4d379903759da817555d66 - missing:
JBIDE-24119-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ISessionFactory-Improve-the-test-for-ISessionFactory-getAllCollectionMetadata https://github.com/jbosstools/jbosstools-hibernate/commit/38be5076b7a55507900ff604f71144adf7b718e5 - missing:
JBIDE-24119-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ISessionFactory-Improve-the-test-for-ISessionFactory-getAllClassMetadata https://github.com/jbosstools/jbosstools-hibernate/commit/3d66b53824a7f988119d7f629b6c9a279ad69e30 - missing:
JBIDE-24119-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ISessionFactory-Add-a-test-for-ISessionFactory-getAllClassMetadata https://github.com/jbosstools/jbosstools-hibernate/commit/3e1f169d7cf412b9bab1f111787b82b2d3cc4a58 - missing:
JBIDE-24119-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ISessionFactory-Add-a-test-for-ISessionFactory-close https://github.com/jbosstools/jbosstools-hibernate/commit/dc65019bffbf3505d27dd4b0a8c3a2e8acc5e9d4 - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-getIdentifierValue https://github.com/jbosstools/jbosstools-hibernate/commit/b34a6c14d46c0854fb47338971531b7d200b0df1 - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-isPhysicalTable https://github.com/jbosstools/jbosstools-hibernate/commit/8e3474fbd510f5302ccdfb6f9707fb4ecfbb91c5 - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-isAbstractUnionTable https://github.com/jbosstools/jbosstools-hibernate/commit/7d54546fbbc7aebc68aa3cf75984f125bd05b10a - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-isAbstract https://github.com/jbosstools/jbosstools-hibernate/commit/773a6c893224328ea1b618ca9ec829e676571631 - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-hasDenormalizedTables https://github.com/jbosstools/jbosstools-hibernate/commit/f55bc1ce42b4a0f5ed861d33303f8ca0379f1e49 - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-getSubselect https://github.com/jbosstools/jbosstools-hibernate/commit/8fd5bf4fa27ad7a6103e2704181572eafddedc71 - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-getRowId https://github.com/jbosstools/jbosstools-hibernate/commit/2811f5f121d2c0c8eddb2317e1a352d158fbd8b5 - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-getComment https://github.com/jbosstools/jbosstools-hibernate/commit/0b518e772f1f820104bbec887eb164efb4fda354 - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-getColumnIterator https://github.com/jbosstools/jbosstools-hibernate/commit/2824129c12cb109ecfd244578cbf9314799bd0fe - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-getPrimaryKey https://github.com/jbosstools/jbosstools-hibernate/commit/7f9d22dda865c29c377db839fddec77c209c5bba - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-getSchema https://github.com/jbosstools/jbosstools-hibernate/commit/46b3ba159f099561c9fefd1975af2ff30f1c418b - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-getCatalog https://github.com/jbosstools/jbosstools-hibernate/commit/fe11b332c4e570ae707dc9592210ae31225a59f0 - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-setPrimaryKey-IPrimaryKey https://github.com/jbosstools/jbosstools-hibernate/commit/b304636469e2ece0dab0c92d0c26c3de1b89c06b - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-addColumn-IColumn https://github.com/jbosstools/jbosstools-hibernate/commit/4225a7f9844922e1fcbefd915e520691fd764236 - missing:
JBIDE-24045-Create-tests-for-the-implementations-of-org.jboss.tools.hibernate.runtime.spi.ITable-Add-test-for-ITable-getName https://github.com/jbosstools/jbosstools-hibernate/commit/2f9d9ca8bd68b7ca3c0f4dff1ae5e80b4f4eaf48 - missing:
JBIDE-24040-Update-hibernate-tools-dependency-of-org.jboss.tools.hibernate.runtime.v_5_0-to-version-5.0.5.Final https://github.com/jbosstools/jbosstools-hibernate/commit/3011a2bf070a7f43ee33cf705a1fd6a97bdf8812 - missing:
JBIDE-24038-Update-hibernate-tools-dependency-of-org.jboss.tools.hibernate.runtime.v_5_1-to-version-5.1.3.Final https://github.com/jbosstools/jbosstools-hibernate/commit/5302313fb66951dc064b4e2b7d0ac9801c1993b8 - missing:
JBIDE-24034-Update-hibernate-tools-dependency-of-org.jboss.tools.hibernate.runtime.v_5_2-to-version-5.2.2.Final https://github.com/jbosstools/jbosstools-hibernate/commit/84491ca5287e9fb28cbedf3bf3167ef2592af563 - missing:
JBIDE-24028-Update-version-identifiers-to-5.2.0-SNAPSHOT https://github.com/jbosstools/jbosstools-hibernate/commit/4219da69dcb665173b6ffa7fceb20820a284b35c - missing:
JBIDE-23951-comment-bump-up-to-parent-pom-version-4.5.0.AM1-SNAPSHOT-close https://github.com/jbosstools/jbosstools-hibernate/commit/8279ee41dc552d279bd2372db76f968ad2540109