Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-24114

[parent pom] do not skip baseline comparison check when -DskipTests=true

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 4.4.4.AM1, 4.5.0.AM1
    • Fix Version/s: 4.4.4.AM2, 4.5.0.AM1
    • Component/s: build
    • Labels:
      None

      Description

      Currently, when you build with -DskipTests, the baseline checks are also skipped. This means that if you make a change to a file in a plugin, and build it locally to see if anything breaks, but forget to bump the version of the plugin and its containing feature, you won't see the baseline check failure until it's built in Jenkins and someone like me complains about it to you directly.

      This happened recently in the 4.4.x branch for changes to openshift and base.

      So I propose this change in parent pom for 4.4.x and master branches:

      -               <skipBaselineComparison>${skipTestsOrITests}</skipBaselineComparison>
      +               <skipBaselineComparison>false</skipBaselineComparison>
      

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                jeffmaury Jeff MAURY
                Reporter:
                nickboldt Nick Boldt
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: