Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-23415

use Import-Package instead of Require-Bundle for slf4j.api [livereload]

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • 4.4.2.AM3
    • 4.4.2.AM2
    • livereload, rpm
    • None

      Because livereload tools use Require-Bundle instead of Import-Package to depend on slf4j.api, this project cannot use the rhel implementation (rh-common-java rpm) version of slf4j.api 1.7.4 .jar when installed via rpm on rhel/fedora.

      Here's the line that is causing the problem:

      https://github.com/jbosstools/jbosstools-livereload/blob/44af911aba916f0e4352a3c6a7961986bbb7d1db/tests/org.jboss.tools.livereload.test/META-INF/MANIFEST.MF#L36

      We need to switch to using Import-Package to that any implementation of this package, regardless of Bundle-SymbolicName, can be used.

      More info in JBDS-4136

      See also:

      http://stackoverflow.com/questions/13959891/why-do-we-need-imported-packages-when-we-have-required-plug-ins-in-eclipse-p
      http://stackoverflow.com/questions/1865819/when-should-i-use-import-package-and-when-should-i-use-require-bundle

              xcoulon@redhat.com Xavier Coulon
              nickboldt Nick Boldt
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: