Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-21331

Connection wizard: it looks as if the wizard is creating new connection instances several times

XMLWordPrintable

    • 2

      The connection wizard creates new connection instances in several places which seems unnecessary (we need it at least once where we dont want to modify an existing connection and operate on a copy before merging the changes back upon successfull verification)

      ConnctionWizardPageModel
       
      	private void initEditConnection(IConnection connection) {
      		this.selectedConnection = connection;
      		this.connection = connection.clone();
      		...
      
      ConnctionWizardPageModel
       
      	public IStatus connect() {
      		...
      		try {
      			this.connection = createConnection();
      		...
      

              adietish@redhat.com André Dietisheim
              adietish@redhat.com André Dietisheim
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: