Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-20330

Port Forwarding Wizard : OpenshiftPreferencePage uses Java 8 API

    Details

      Description

      https://github.com/jbosstools/jbosstools-openshift/blob/35496b287c1849f7a2075384498ba572f45d1b96/plugins/org.jboss.tools.openshift.ui/src/org/jboss/tools/openshift/internal/ui/preferences/OpenShiftPreferencePage.java#L137 uses

      process.waitFor(500, TimeUnit.MILLISECONDS)
      

      which is only available in Java 8, whereas the plugin is meant to compile/run with Java 7.

      I found this ugly workaround to implement a process timeout in Java 7 : http://stackoverflow.com/questions/808276/how-to-add-a-timeout-value-when-using-javas-runtime-exec

      The alternative is to raise the Java BREE to JavaSE-1.8. But that was something Max Andersen wasn't keen on doing when the whole JBDS requirement bumped to Java 8 (we want to be able to rollback to using Java 7 if the users demand it)

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  adietish André Dietisheim
                  Reporter:
                  fbricon Fred Bricon
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: