Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-20177

migrate skipRevisionCheckWhenPublishing and checkLatestPublishedSHA into jbosstools-releng-publish deploy mojo

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Do
    • Major
    • 4.5.3.Final
    • 4.3.0.Beta1
    • build
    • None

    Description

      If we can migrate this logic into the mojo...

      if [[ ${skipRevisionCheckWhenPublishing} == "true" ]] || [[ $(. ${WORKSPACE}/sources/util/checkLatestPublishedSHA.sh -s ${WORKSPACE}/sources/aggregate/${projectName}-site/target/fullSite/all/repo -t http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-build-sites.aggregate.${projectName}-site_${jbosstools_site_stream}/latest/all/repo/) == "true" ]]; then

      ... we'll be able to remove this step in all jobs:

          <hudson.tasks.Maven>
      <targets>-U -e org.apache.maven.plugins:maven-dependency-plugin:2.9:unpack</targets>
      <mavenName>maven-3.2.5</mavenName>
      <properties>artifact=org.jboss.tools.releng:jbosstools-releng-publish:4.3.0.Beta2-SNAPSHOT:zip
outputDirectory=${WORKSPACE}/sources
trimVersion=true
mdep.stripClassifier=true
mdep.stripVersion=true</properties>
      <usePrivateRepository>false</usePrivateRepository>
      <settings class="jenkins.mvn.DefaultSettingsProvider"/>
      <globalSettings class="jenkins.mvn.DefaultGlobalSettingsProvider"/>
    </hudson.tasks.Maven>

      ... and instead, just pass in those vars to maven:

      -DskipRevisionCheckWhenPublishing=${skipRevisionCheckWhenPublishing}
-DcheckLatestPublishedSHA_SOURCE_PATH=${WORKSPACE}/sources/aggregate/${projectName}-site/target/fullSite/all/repo
-DcheckLatestPublishedSHA_TARGET_PATH=http://download.jboss.org/jbosstools/mars/snapshots/builds/jbosstools-build-sites.aggregate.${projectName}-site_${jbosstools_site_stream}/latest/all/repo/

      Attachments

        Issue Links

          is related to

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) JBIDE-16970 create mechanism to verify that nightly build is different from previous milestone

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          relates to

          Bug - A problem that impairs or prevents the functions of the product. JBIDE-20148 releng scripts is an outdated version; jobs are not seeing latest from Nexus

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) JBIDE-15388 Compute whether to publish or not based on output signature rather than commits

          • Minor - To be worked after urgent, high, and medium priorities are resolved. This term is chosen when the severity of the issue is low, or the complexity or effort to correct it may be higher, relatively speaking. For low priority issues, known workarounds exist or are not needed due to the trivial effort needed to address the issue.
          • Closed

          Activity

            People

              nickboldt Nick Boldt
              nickboldt Nick Boldt
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: