Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-19181

correct naming of internal packages so that they're consistent across all openshift plugins

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Major Major
    • 4.30.x
    • 4.3.0.Alpha1
    • openshift
    • None

      Internal packages across the openshift plugins are non-consistent:

      ex.
      org.jboss.tools.openshift.client: org.jboss.tools.openshift.client.internal
      org.jboss.tools.openshift.express.client: org.jboss.tools.openshift.express.client.internal

      the base is imho org.jboss.tools.openshift and thus internal packages should always be at org.jboss.tools.openshift.internal across plugins.
      For reference, here's the official Eclipse documentation on the topic: http://wiki.eclipse.org/index.php/Naming_Conventions#Java_Packages

      org.eclipse.jdt.internal.core.compiler - Correct usage
      org.eclipse.jdt.core.internal.compiler - Incorrect. internal should immediately follow subproject name.
      org.eclipse.core.internal.resources - Correct usage
      org.eclipse.internal.core.resources - Incorrect. internal should never immediately follow org.eclipse.
      org.eclipse.core.resources.internal - Incorrect. internal should immediately follow Eclipse Platform component name.

              Unassigned Unassigned
              adietish@redhat.com André Dietisheim
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: