Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-15332

stop linking skipRequirements and tests.skip to download of requirements

    XMLWordPrintable

Details

    • Enhancement
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Out of Date
    • 4.2.0.Beta1
    • 4.5.0.AM2
    • build

    Description

      I stumbled on nivologd@gmail.com's patch for livreload at https://github.com/jbosstools/jbosstools-livereload/pull/54/files

      This is not the first time i've seen skip having to be enabled for plain normal mvn dependencies.

      skipRequirements are supposed to only cover big downloads (like EAP, jboss etc.) - things done via non-maven download mechanism.

      Why is this applied to mvn dependency downloads ?

      The culprit for needing this line is at:
      https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L397

      and a bugzilla (not jira?!) is referenced as the reason for this back in 2012: https://github.com/jbosstools/jbosstools-build/commit/2e18baaf88e0cd73b3b99885658e00789e8fd198

      I understand why the explicit google download plugin (why is there two versions used btw?) but why is skipTests controlling normal mvn dependency download ? Which requirements are using this for download ?

      Attachments

        Issue Links

          Activity

            People

              nickboldt Nick Boldt
              manderse@redhat.com Max Andersen
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: