-
Sub-task
-
Resolution: Done
-
Major
-
None
Given
ShrinkWrap.create(WebArchive.class, "test.jar") ShrinkWrap.create(WebArchive.class, "test.ear") ShrinkWrap.create(JavaArchive.class, "test.ear") ShrinkWrap.create(WebArchive.class, "test")
When
User is creating a Archive
Then
The known Archive types should match given archive name extensions.
Expected
Warning; Creating an archive of type WebArchive but given name does not match to predefined name extension; .war
Actual
Nothing.. waits for Arquillian to fail.
This is a very common and annoying user error. The Container/Server will 99% of the time rely on the deployment file extension to determine what type of archive this is. While our 'WebArchive' Archive types are only convenience views on how to add data to correct locations within the target archive and can be any type; we choose to validate this runtime in Arquillian core to warn that 'hey, this is probably not what you intended to do' to hopefully save users from a few hours pointless debugging.
See https://github.com/arquillian/arquillian-core/blob/master/container/spi/src/main/java/org/jboss/arquillian/container/spi/client/deployment/Validate.java#L45 for our extension type mapping.
Our validation logic is; if extension does not match, but Archive is of Type then warn.
That allows users to use Custom views without warning.
- is related to
-
JBIDE-14781 'Generate Deployment Method Dialog' should warn of Type and Name.extension missmatch
-
- Closed
-
- relates to
-
JBIDE-15657 Add quickfix for invalid archive name marker
-
- Closed
-