Details

    • Type: Sub-task
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.3.0.M4
    • Fix Version/s: 3.3.0.M5
    • Component/s: common
    • Labels:
      None

      Description

      XModelObjectAction line 145:

      		item.setImage(eclipseAction.getImageDescriptor().createImage());
      

      LabelDecoratorImpl lines 53, 63:

      			i = d.createImage();
      
      • here is extra strange logic and you use:
        	public static Image emptyImage = ModelUIImages.getImage("empty_co.gif"); //$NON-NLS-1$
        	public static Image errorImage = ModelUIImages.getImage("error_co.gif"); //$NON-NLS-1$
        	public static Image warningImage = ModelUIImages.getImage("warning_co.gif"); //$NON-NLS-1$
        
        	List<ILabelProviderListener> listeners = new ArrayList<ILabelProviderListener>();
        	static Map<Image,Image> errorImages = new HashMap<Image,Image>();
        	static Map<Image,Image> warningImages = new HashMap<Image,Image>();
        
      • which are never disposed.

      AbstractQueryDialog line 46:

      		setTitleImage(ModelUIImages.getImageDescriptor(ModelUIImages.WIZARD_DEFAULT).createImage(null));
      

      AbstractQueryWizardView line 153:

      			titleDialog.setTitleImage(ModelUIImages.getImageDescriptor(ModelUIImages.WIZARD_DEFAULT).createImage(null));
      

      DefaultSpecialWizardDialog line 56:

      		this.setTitleImage(ModelUIImages.getImageDescriptor(ModelUIImages.WIZARD_DEFAULT).createImage(null));
      

      ModelUIImages lines 58 & 98:

      	public static Image getImage(String key) {                   <------------------ create Image not get
      		if(ModelUIPlugin.isDebugEnabled()) {
      			ModelUIPlugin.getPluginLog().logInfo("Create image for key '"+key+"'."); //$NON-NLS-1$ //$NON-NLS-2$
      		}
      		return INSTANCE.createImageDescriptor(key).createImage();
      	}
      ...
      	public Image getImageByFileName(String key) {                 <------------------ create Image not get
      		return createImageDescriptor(key).createImage();
      	}
      
      • is necessary to check all places where these methods call exist.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                scabanovich Viacheslav Kabanovich
                Reporter:
                vyemialyanchyk Vitali Yemialyanchyk
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: