Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-10221 Resorce leak problems in JBossTools
  3. JBIDE-10220

org.jboss.tools.common.model.ui has a lot of resorce leaks

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.3.0.M4
    • Fix Version/s: 3.3.0.Beta1
    • Component/s: common
    • Labels:
      None

      Description

      1) TextEditorComponent has resorce leak problem -> it create Color, but does not dispose it -> org.jboss.tools.common.model.ui.texteditors.TextEditorComponent line 186:

      return (rgb != null) ? new Color(display, rgb) : null;
      

      firstly I find this with TextEditorComponent... but org.jboss.tools.common.model.ui has a lot of Color leaks - try to search "new Color(":
      2) org.jboss.tools.common.model.ui.widgets.WhiteSettings
      3) org.jboss.tools.common.model.ui.attribute.editor.ExtendedFieldEditor

      • in these places Color created constantly, but never disposed.

      in this plugin I've find a lot of commented "new Color(" - should be deleted to avoid leaks after "just uncomment",
      and there are places with "static Color" declarations - which at least looks very "questionable".

        Attachments

          Activity

            People

            Assignee:
            scabanovich Viacheslav Kabanovich (Inactive)
            Reporter:
            vyemialyanchyk Vitali Yemialyanchyk (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: