Uploaded image for project: 'JBoss Enterprise Application Platform'
  1. JBoss Enterprise Application Platform
  2. JBEAP-9149

slow-consumer-check-period is in minutes but behaves like with seconds

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Do
    • Major
    • None
    • 7.1.0.DR12
    • ActiveMQ
    • None
    • Hide

      Steps to reproduce - this is not 100% reproducer but I can hit the issue in (70% of runs)

      git clone git://git.app.eng.bos.redhat.com/jbossqe/eap-tests-hornetq.git
      cd eap-tests-hornetq/scripts/
      git checkout master
      
      groovy -DEAP_VERSION=7.1.0.DR12 PrepareServers7.groovy
      export WORKSPACE=$PWD
      export JBOSS_HOME_1=$WORKSPACE/server1/jboss-eap
      export JBOSS_HOME_2=$WORKSPACE/server2/jboss-eap
      export JBOSS_HOME_3=$WORKSPACE/server3/jboss-eap
      export JBOSS_HOME_4=$WORKSPACE/server4/jboss-eap
      
      cd ../jboss-hornetq-testsuite/
      # this will execute the test 50 times
      sh repeat_test_until_fail.sh SlowConsumersTestCase#testSlowNonDurableConsumerKill
      
      Show
      Steps to reproduce - this is not 100% reproducer but I can hit the issue in (70% of runs) git clone git: //git.app.eng.bos.redhat.com/jbossqe/eap-tests-hornetq.git cd eap-tests-hornetq/scripts/ git checkout master groovy -DEAP_VERSION=7.1.0.DR12 PrepareServers7.groovy export WORKSPACE=$PWD export JBOSS_HOME_1=$WORKSPACE/server1/jboss-eap export JBOSS_HOME_2=$WORKSPACE/server2/jboss-eap export JBOSS_HOME_3=$WORKSPACE/server3/jboss-eap export JBOSS_HOME_4=$WORKSPACE/server4/jboss-eap cd ../jboss-hornetq-testsuite/ # this will execute the test 50 times sh repeat_test_until_fail.sh SlowConsumersTestCase#testSlowNonDurableConsumerKill

    Description

      Attribute slow-consumer-check-period is in minutes but {{SlowConsumerReaperRunnable} thread is scheduled as it's configured with seconds.

      Problem is in QueueImpl.scheduleSlowConsumerReaper method:

      slowConsumerReaperFuture = scheduledExecutor.scheduleWithFixedDelay(slowConsumerReaperRunnable, settings.getSlowConsumerCheckPeriod(), settings.getSlowConsumerCheckPeriod(), TimeUnit.SECONDS);
      

      contains TimeUnit.SECONDS instead of TimeUnit.MINUTES.

      I tried to debug it and can see that settings.getSlowConsumerCheckPeriod() returns 1 which is in minutes. This seems to be easy fix.

      Attachments

        Issue Links

          Activity

            People

              rh-ee-ataylor Andy Taylor
              mnovak1@redhat.com Miroslav Novak
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: