This jira follows JBEAP-4593. I would like ask for changes in Transaction chapter of EAP Development Guide in section 12.3.2.1. Commit Markable Resource.

My point here is that XML examples and CLI examples are not fully consistent. These are my observations:

• when creating datasource there is provided wrong attribute name exception-sorter. It has to be changed to correct one exception-sorter-class-name
• when the provided cli command is run then datasource itself consist from more than of the first provided line. I think the xml snippet should be consistent with that created by cli and it should be full like

  <datasource jta="true" jndi-name="java:jboss/datasources/ConnectableDS" pool-name="ConnectableDS" enabled="true" use-java-context="true" connectable="true">
    <connection-url>validConnectionURL</connection-url>                    
    <driver>h2</driver>
    <validation>
      <exception-sorter class-name="org.jboss.jca.adapters.jdbc.extensions.mssql.MSSQLExceptionSorter"/>
    </validation>
  </datasource>
  

• there is an issue with usage of driver h2 in the example. We show that exception sorter should be used. And it's a point. The exception sorter of JCA layer consist logic that changes error handling behaviour, especially return codes put up to TM. When CMR is used the exception sorter needs to be defined - at least for supported databases. H2 is not supported DB and ironjacamar does not provide an exception sorter implementation for it. We end in situation that driver name refers to h2 but exception sorter to mssql. For creating datasource we have to have defined driver name otherwise cli command throws error. I suggest to instead of driver-name="h2" to use driver-name="mssql". And add a note on datasource creation where we say that datasource needs to have defined a valid driver and pointing user to fact that mssql does not exist. Plus adding a link to configuration guide would be fine (where details are explained).
• Note Use the exception-sorter parameter in the datasource configuration. For details, see Example Datasource Configurations in the JBoss EAP Configuration Guide. should be moved upward to the section where datasource is created (now it's part of Add Reference to Transaction Subsystem which is not much relevant).
• section Enabling Datasource to be Connectable uses wording ensure that the connectible attribute is set to true but the attribute is not called connectible but connectable. Please change back to the connectable as that's how it has to be put to cli command.