Uploaded image for project: 'JBoss Enterprise Application Platform'
  1. JBoss Enterprise Application Platform
  2. JBEAP-27761

[GSS](7.4.z) WFLY-19671 - Remove "galleon content only" dependencies from list of feature pack deps

XMLWordPrintable

      When building feature packs we bring in a number of "galleon content only" artifacts and use them as source to build the feature pack. We list some (but not all) of the poms associated with these as maven dependencies of the feature pack build. This has the downside of having those deps appear in the built feature pack's resources/wildfly/artifact-version.properties file even though the relevant artifacts are not needed for provisioning.

      It turns out listing these in FP build's maven dependencies is not needed to get the FP to build or function properly. So they can be dropped.

      Including them in artifact-version.properties increases the fragility of the use of the feature pack as it results in a requirement that they artifacts be available in maven if the wildfly-galleon-plugin build-feature-pack goal is used to build a feature pack that depends on our FPs. This results in an unnecessary requirement for internal build artifacts to be present in maven repos used to support such use of the feature pack.

      I'm specifically talking about org.wildfly.core:wildfly-core-feature-pack-galleon-common here. In 7.4.x there are others.

      The key characteristic here is the poms for these artifacts are not used to control the version of dependencies that end up being provisioned. This is because the galleon content they provide doesn't include any Galleon packages (typically JBoss Modules modules) that incorporate an artifact. Other maven modules likeĀ 
      org.wildfly.core:wildfly-core-feature-pack-common do define dependency versions, and need to be listed as dependencies in the feature pack pom.

            bstansbe@redhat.com Brian Stansberry
            bstansbe@redhat.com Brian Stansberry
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: