Uploaded image for project: 'JBoss Enterprise Application Platform'
  1. JBoss Enterprise Application Platform
  2. JBEAP-24375

[GSS](7.4.z) UNDERTOW-2214 - Jastow compilation error when mixing EL and scriptlet expressions after UNDERTOW-1319

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 7.4.10.CR1, 7.4.10.GA
    • 7.4.8.GA
    • Undertow
    • None

    Description

      UNDERTOW-1319 added the ability to use a partial scriptlet expression in attributes. But there are two reasons to revert this:

      • The spec only allows full expression scriptlet attributes in a JSP tag. So an attribute like attribute="/path/to/<%= ... %>" should not be interpreted. In the chapter Request Time Attribute Values says:

       

      When using scriptlet expressions, the expression must appear by itself (multiple expressions, and mixing of expressions and string constants are not permitted).

       

      • The fix for UNDERTOW-1319 is incomplete and triggers new issues that are not present in previous versions. For example if the attribute mixes EL and scriptlet expressions an exception can be thrown. For example to the tag:

       

      <c:out value="\"function(<%= Boolean.TRUE %>, ${Boolean.TRUE}})\""/>
      

      This generates a compilation error: Syntax error, insert ")" to complete MethodInvocation.

      In summary UNDERTOW-1319 is not covered by the jakarta specification and allowing such mixed scenarios is not as easy as it seemed. Why not more than one expressions scriptlet? Why not mixing EL and scriplet expressions? The complete feature is very complicated and that probably was the reason to only allow full attribute expression scriptlets in the spec.

      Better revert the PR for UNDERTOW-1319 and be fully spec complaint.

      Attachments

        Issue Links

          Activity

            People

              rhn-support-rmartinc Ricardo Martin Camarero
              rhn-support-bmaxwell Brad Maxwell
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: