Uploaded image for project: 'JBoss Enterprise Application Platform'
  1. JBoss Enterprise Application Platform
  2. JBEAP-19762

[GSS](7.2.z) JSFDependencyProcessor not reporting ModuleLoadException cause

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Do
    • Major
    • None
    • 7.2.9.GA
    • JSF
    • None

    Description

       

       

      org.jboss.as.jsf.deployment.JSFDependencyProcessor

       

      This catch can hide the root exception, for example user had old module.xml xsd version which was failing to parse, so it fails , throws an exception and logs

      153         } catch (ModuleLoadException e) {
154             throw JSFLogger.ROOT_LOGGER.jsfInjectionFailed(jsfVersion);
155         }
       16:17:32,765 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-3) MSC000001: Failed to start service jboss.deployment.unit."admin2.war".DEPENDENCIES: org.jboss.msc.service.StartException in service jboss.deployment.unit."admin2.war".DEPENDENCIES: WFLYSRV0153: Failed to process phase DEPENDENCIES of deployment "admin2.war"
	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:151)
	at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1739)
	at org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1701)
	at org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1559)
	at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
	at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1985)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1487)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1378)
	at java.lang.Thread.run(Thread.java:748)
Caused by: org.jboss.as.server.deployment.DeploymentUnitProcessingException: WFLYJSF0016: Failed to inject JSF from slot Mojarra-2.0
	at org.jboss.as.jsf.deployment.JSFDependencyProcessor.addJSFInjection(JSFDependencyProcessor.java:155)
	at org.jboss.as.jsf.deployment.JSFDependencyProcessor.deploy(JSFDependencyProcessor.java:95)
	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:144)
	... 8 more

       

      When the root exception is :

      16:17:32,761 ERROR [stderr] (MSC service thread 1-3) org.jboss.modules.ModuleLoadException: Error loading module from /Users/bmaxwell/work/source/git/gss-git/jboss-eap7-one-off/dist/target/jboss-eap-7.2/modules/org/jboss/as/jsf-injection/Mojarra-2.0/module.xml
16:17:32,761 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.xml.ModuleXmlParser.parseModuleXml(ModuleXmlParser.java:313)
16:17:32,761 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.xml.ModuleXmlParser.parseModuleXml(ModuleXmlParser.java:269)
16:17:32,761 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.xml.ModuleXmlParser.parseModuleXml(ModuleXmlParser.java:230)
16:17:32,761 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.LocalModuleFinder.parseModuleXmlFile(LocalModuleFinder.java:250)
16:17:32,761 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.LocalModuleFinder.lambda$findModule$1(LocalModuleFinder.java:195)
16:17:32,762 ERROR [stderr] (MSC service thread 1-3) 	at java.security.AccessController.doPrivileged(Native Method)
16:17:32,762 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.LocalModuleFinder.findModule(LocalModuleFinder.java:195)
16:17:32,762 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.ModuleLoader.findModule0(ModuleLoader.java:696)
16:17:32,762 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.ModuleLoader.findModule(ModuleLoader.java:689)
16:17:32,762 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.ModuleLoader.loadModuleLocal(ModuleLoader.java:499)
16:17:32,762 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.DelegatingModuleLoader.preloadModule(DelegatingModuleLoader.java:57)
16:17:32,762 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.ModuleLoader.loadModule(ModuleLoader.java:295)
16:17:32,762 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.as.jsf.deployment.JSFDependencyProcessor.isJSF12(JSFDependencyProcessor.java:164)
16:17:32,763 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.as.jsf.deployment.JSFDependencyProcessor.addJSFInjection(JSFDependencyProcessor.java:143)
16:17:32,763 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.as.jsf.deployment.JSFDependencyProcessor.deploy(JSFDependencyProcessor.java:95)
16:17:32,763 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:144)
16:17:32,763 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1739)
16:17:32,763 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1701)
16:17:32,763 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1559)
16:17:32,763 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
16:17:32,763 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1985)
16:17:32,764 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1487)
16:17:32,764 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1378)
16:17:32,764 ERROR [stderr] (MSC service thread 1-3) 	at java.lang.Thread.run(Thread.java:748)
16:17:32,764 ERROR [stderr] (MSC service thread 1-3) Caused by: org.jboss.modules.xml.XmlPullParserException: Unknown attribute "slot" from namespace "" (position: START_TAG seen ...as.jsf-injection" slot="Mojarra-2.0" xmlns="urn:jboss:module:1.8">... @2:91) 
16:17:32,764 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.xml.ModuleXmlParser.unknownAttribute(ModuleXmlParser.java:370)
16:17:32,764 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.xml.ModuleXmlParser.parseModuleContents(ModuleXmlParser.java:618)
16:17:32,764 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.xml.ModuleXmlParser.parseDocument(ModuleXmlParser.java:440)
16:17:32,764 ERROR [stderr] (MSC service thread 1-3) 	at org.jboss.modules.xml.ModuleXmlParser.parseModuleXml(ModuleXmlParser.java:311)
16:17:32,764 ERROR [stderr] (MSC service thread 1-3) 	... 23 more

       

      We should include the cause by in the exception so that we do not have to use byteman or other to find the root cause.

       

      Attachments

        Issue Links

          incorporates

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) WFLY-12487 Include the original cause of deployment failure when trying to find jsf-injection module

          • Minor - To be worked after urgent, high, and medium priorities are resolved. This term is chosen when the severity of the issue is low, or the complexity or effort to correct it may be higher, relatively speaking. For low priority issues, known workarounds exist or are not needed due to the trivial effort needed to address the issue.
          • Closed
          links to

          Web Link KCS

          Activity

            People

              mshikalw Moulali Shikalwadi
              rhn-support-bmaxwell Brad Maxwell
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: