The following fixes in Hibernate ORM 5.3.15.Final cause org.jboss.as.test.integration.jpa.cfgfile.CfgFileTestCase to fail:
There are 2 assertions in the test that fail with those fixes because the Map returned by EntityManagerFactory#getProperties:
1) does not contain a value for property hibernate.connection.driver_class.
2) contains a property for hibernate.connection.datasource that is a WildFlyDataSource instance, instead of the String "java:jboss/datasources/ExampleDS".
For 1), Hibernate ORM removes the hibernate.connection.driver_class property from its copy because it makes no sense when a datasource is provided via hibernate.connection.datasource.
For 2), Hibernate ORM replaces the String value for hibernate.connection.datasource with the WildFlyDataSource instance.
I reviewed the JPA 2.2 specification and discussed this issue with email@example.com, and we agreed that these were acceptable changes to the copy of properties that Hibernate ORM contains.
I have confirmed that these fixes do not cause any Jakarta standalone TCK failures.
The fix will involve replacing references to those properties with properties that Hibernate ORM does not change.