Uploaded image for project: 'JBoss Enterprise Application Platform'
  1. JBoss Enterprise Application Platform
  2. JBEAP-12444

Log messages without prefixed id code in artemis-core-client

    XMLWordPrintable

Details

    • Bug
    • Resolution: Obsolete
    • Minor
    • None
    • 7.1.0.DR8, 7.1.0.DR18
    • ActiveMQ
    • None
    • Hide

      Run following command in artemis-core-client directory

      [treblereel@dhcp-10-40-4-236 artemis-core-client]$ find -name "*.java" | grep -i -E -v "test|example|junit" | xargs grep -i -E "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
      ./src/main/java/org/apache/activemq/artemis/core/cluster/DiscoveryGroup.java:                        ActiveMQClientLogger.LOGGER.warn("Unexpected null data received from DiscoveryEndpoint");
      ./src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java:         ActiveMQClientLogger.LOGGER.warn(e.getMessage(), e);
      ./src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerImpl.java:         ActiveMQClientLogger.LOGGER.warn("problem cleaning up: " + this);
      ./src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerImpl.java:                     ActiveMQClientLogger.LOGGER.warn(e.getMessage(), e);
      ./src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java:         ActiveMQClientLogger.LOGGER.warn(e.getMessage(), e);
      ./src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java:         logger.warn(t.getMessage(), t);
      ./src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java:               ActiveMQClientLogger.LOGGER.warn(logOnly.getMessage(), logOnly);
      ./src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java:            ActiveMQClientLogger.LOGGER.warn(e.getMessage(), e);
      ./src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java:         logger.warn("Trying to allocate " + size + " bytes, System is throwing OutOfMemoryError on NettyConnection " + this + ", there are currently " + "pendingWrites: [NETTY] -> " + totalPendingWriteBytes + "[EVENT LOOP] -> " + pendingWritesOnEventLoopView.get() + " causes: " + oom.getMessage(), oom);
      ./src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java:            logger.warn("FAILURE! The code is using blockUntilWritable inside a Netty worker, which would block. " +
      ./src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java:         ActiveMQClientLogger.LOGGER.error("Cannot resolve host", e);
      ./src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/Epoll.java:         logger.warn(e.getMessage(), e);
      ./src/main/java/org/apache/activemq/artemis/utils/VersionLoader.java:            ActiveMQClientLogger.LOGGER.warn(e.getMessage(), e);
      ./src/main/java/org/apache/activemq/artemis/utils/VersionLoader.java:         ActiveMQClientLogger.LOGGER.error(e.getMessage(), e);
      ./src/main/java/org/apache/activemq/artemis/api/core/client/ActiveMQClient.java:               ActiveMQClientLogger.LOGGER.warn("Couldn't finish the client globalThreadPool in less than 10 seconds, interrupting it now");
      ./src/main/java/org/apache/activemq/artemis/api/core/client/ActiveMQClient.java:               ActiveMQClientLogger.LOGGER.warn("Couldn't finish the client scheduled in less than 10 seconds, interrupting it now");
      ./src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java:                  ActiveMQClientLogger.LOGGER.warn(this + " getting exception when receiving broadcasting.", e);
      ./src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java:         ActiveMQClientLogger.LOGGER.warn(t);
      ./src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java:         ActiveMQClientLogger.LOGGER.warn(t.getMessage(), t);
      
      
      
      
      Show
      Run following command in artemis-core-client directory [treblereel@dhcp-10-40-4-236 artemis-core-client]$ find -name "*.java" | grep -i -E -v "test|example|junit" | xargs grep -i -E "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\(" ./src/main/java/org/apache/activemq/artemis/core/cluster/DiscoveryGroup.java: ActiveMQClientLogger.LOGGER.warn( "Unexpected null data received from DiscoveryEndpoint" ); ./src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java: ActiveMQClientLogger.LOGGER.warn(e.getMessage(), e); ./src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerImpl.java: ActiveMQClientLogger.LOGGER.warn( "problem cleaning up: " + this ); ./src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerImpl.java: ActiveMQClientLogger.LOGGER.warn(e.getMessage(), e); ./src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java: ActiveMQClientLogger.LOGGER.warn(e.getMessage(), e); ./src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java: logger.warn(t.getMessage(), t); ./src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java: ActiveMQClientLogger.LOGGER.warn(logOnly.getMessage(), logOnly); ./src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java: ActiveMQClientLogger.LOGGER.warn(e.getMessage(), e); ./src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java: logger.warn( "Trying to allocate " + size + " bytes, System is throwing OutOfMemoryError on NettyConnection " + this + ", there are currently " + "pendingWrites: [NETTY] -> " + totalPendingWriteBytes + "[EVENT LOOP] -> " + pendingWritesOnEventLoopView.get() + " causes: " + oom.getMessage(), oom); ./src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java: logger.warn( "FAILURE! The code is using blockUntilWritable inside a Netty worker, which would block. " + ./src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java: ActiveMQClientLogger.LOGGER.error( "Cannot resolve host" , e); ./src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/Epoll.java: logger.warn(e.getMessage(), e); ./src/main/java/org/apache/activemq/artemis/utils/VersionLoader.java: ActiveMQClientLogger.LOGGER.warn(e.getMessage(), e); ./src/main/java/org/apache/activemq/artemis/utils/VersionLoader.java: ActiveMQClientLogger.LOGGER.error(e.getMessage(), e); ./src/main/java/org/apache/activemq/artemis/api/core/client/ActiveMQClient.java: ActiveMQClientLogger.LOGGER.warn( "Couldn't finish the client globalThreadPool in less than 10 seconds, interrupting it now" ); ./src/main/java/org/apache/activemq/artemis/api/core/client/ActiveMQClient.java: ActiveMQClientLogger.LOGGER.warn( "Couldn't finish the client scheduled in less than 10 seconds, interrupting it now" ); ./src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java: ActiveMQClientLogger.LOGGER.warn( this + " getting exception when receiving broadcasting." , e); ./src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java: ActiveMQClientLogger.LOGGER.warn(t); ./src/main/java/org/apache/activemq/artemis/api/core/UDPBroadcastEndpointFactory.java: ActiveMQClientLogger.LOGGER.warn(t.getMessage(), t);

    Description

      Log message should contain its identifier followed by text description. It should look like following one:

      AMQ221003: Deploying queue jms.queue.DLQ
      

      However, some of log messages doesn't follow this "id: description" pattern. Attachment [^incorrect_logs.txt] contains list of places, where log message without prefixed id is logged. It contains only log messages for error, warn and info level.

      Attachments

        Issue Links

          Activity

            People

              dtikhomi@redhat.com Dmitrii Tikhomirov
              dtikhomi@redhat.com Dmitrii Tikhomirov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: