-
Enhancement
-
Resolution: Done
-
Minor
-
7.1.0.DR16
-
None
There are several input validators for custom path input fields, but their order differs accross installer, eg.:
<field type="dir" align="left" variable="install.quickstarts.path" defaultFocus="true"> ... <validator class="com.redhat.installer.installation.validator.WritablePathValidator" id="TargetPanel.notwritable" ></validator> <validator class="com.redhat.installer.installation.validator.DirectoryValidator" id="TargetPanel.invalid"/> <validator class="com.redhat.installer.installation.validator.EmptyPathValidator" id="quickstarts.nonempty.path"/> </field>
<field type="file" align="left" variable="vault.keystoreloc" tooltip="vault.path.tooltip"> ... <validator class="com.redhat.installer.installation.validator.DirectoryValidator" id="vault.keystore.invalid.path"/> <validator class="com.redhat.installer.installation.validator.WritablePathValidator" id="vault.path.no.write.permission"/> <validator class="com.redhat.installer.installation.validator.IsFileValidator" id="vault.path.is.directory"/> </field>
I think it is better to use the same order as for Vault panel so that DirectoryValidator is before WritablePathValidator - this way an user is given more valuable info than just "non writeable path" for path with invalid chars.
- DirectoryValidator - check for platform dependant invalid chars for path
- WritablePathValidator - check if it is allowed to write in that path
It would also make sense to rename DirectoryValidator class to something more appropriate
