Product branding is in the wrong place, so gets overwritten when SDK feature is updated

From https://bugs.eclipse.org/bugs/show_bug.cgi?id=263417:

------- Comment #1 From John Arthorne 2009-02-03 11:06:43 -0400 [reply] -------

I think this is user error. I think you are upgrading the branded Eclipse SDK
product (org.eclipse.sdk.ide), rather than the feature (org.eclipse.sdk):

<unit id='org.eclipse.sdk.ide' version='3.4.2.M20090127-1710'>

Rather than the unbranded SDK feature:

<unit id='org.eclipse.sdk' version='3.4.2.v200901211700'>

Products are branded, features aren't. If you install the branded SDK product,
I think it is expected that you get the SDK branding elements. You should
probably be upgrading the feature instead.

------- Comment #2 From Pascal Rapicault 2009-02-04 10:42:41 -0400 [reply] -------

As mentioned by John, the issue lies in how you are creating your metadata for
your product. You need to create your own product and includes the sdk feature
(not the sdk product).