Uploaded image for project: 'Red Hat CodeReady Studio (devstudio)'
  1. Red Hat CodeReady Studio (devstudio)
  2. JBDS-4265

Remove more jgit/egit bundles from devstudio rpm?

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 10.3.0.GA
    • 10.3.0.GA
    • rpm
    • None
    • devex #127 February 2017
    • 10
    • NEW

      Mat asked, re: https://github.com/jbdevstudio/jbdevstudio-product/commit/15972aaaa17a4f87894c824430f109d9be5405a4 :

      Hmm, Devstudio supplies jgit?

      We also supply it as part of RHSCL in package rh-eclipse46-eclipse-jgit.noarch

      $ ls /opt/rh/rh-eclipse46/root/usr/share/eclipse/droplets/jgit/eclipse/plugins
      com.googlecode.javaewah.JavaEWAH_0.8.4.jar
      com.google.gson_2.2.4.jar
      org.apache.commons.compress_1.5.0.jar
      org.eclipse.jgit_4.6.0.201612231935-r.jar
      org.eclipse.jgit.archive_4.6.0.201612231935-r.jar
      org.eclipse.jgit.http.apache_4.6.0.201612231935-r.jar
      org.eclipse.jgit.http.server_4.6.0.201612231935-r.jar
      org.eclipse.jgit.junit_4.6.0.201612231935-r.jar
      org.eclipse.jgit.junit.http_4.6.0.201612231935-r.jar
      org.eclipse.jgit.lfs_4.6.0.201612231935-r.jar
      org.eclipse.jgit.lfs.server_4.6.0.201612231935-r.jar
      org.eclipse.jgit.pgm_4.6.0.201612231935-r.jar
      org.eclipse.jgit.ui_4.6.0.201612231935-r.jar
      org.hamcrest.core_1.3.0.v201303031735.jar
      org.junit_4.12.0.jar
      org.kohsuke.args4j_2.32.0.jar
      slf4j.api_1.7.4.jar
      slf4j.simple_1.7.4.jar

      Devstudio REQUIRES jgit:

      https://github.com/jbdevstudio/jbdevstudio-product/blob/master/rpm/devstudio.spec.template#L48

      And we specifically blacklist a lot of egit and jgit bundles. Maybe we need to blacklist more?

      https://github.com/jbdevstudio/jbdevstudio-product/blob/master/rpm/devstudio.removelist.txt#L246

      If it's dragged in by stuff in Openshift or M2E, we'll have to get that fixed in upstream so it's only Import-Package'ing instead of Require-Bundle'ing.

      https://github.com/jbdevstudio/jbdevstudio-product/blob/master/features/com.jboss.devstudio.core.rpm.feature/feature.xml#L49
      https://github.com/jbdevstudio/jbdevstudio-product/blob/master/features/com.jboss.devstudio.core.rpm.feature/feature.xml#L90

            nickboldt Nick Boldt
            nickboldt Nick Boldt
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: