• Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 5.0.0.Beta3
    • 4.0.0.GA
    • updatesite
    • None

      Not sure if this qualifies as a bug or a feature request but
      I noticed that if I use JBDS 4 updatesite against plain Eclipse things seem to work great
      until you restart (possible on the second restart) since then it suddenly has zero
      extra memory allocated.

      It only started working properly when using the jbdevstudio.app; thus my assumption is that
      eclipse.ini is ignored and jbdevstudio.ini is looked for instead but this file is nowhere
      to be found (except inside jbdevstudio.app)

      Would be good if we could handle this situation more gracefully since the shortcuts users
      uses still points to eclipse thus they will see it as JBDS running out of memory since when launching
      it says JBDS.

            [JBDS-1577] Installing JBDS into Eclipse 3.6 works, but runs out of memory

            Verified, I expect this is valid for JBDS installation on Eclipse 3.7.2, which works. Tested with JBDS5.0.0.GA bits, L64

            Jiri Peterka (Inactive) added a comment - Verified, I expect this is valid for JBDS installation on Eclipse 3.7.2, which works. Tested with JBDS5.0.0.GA bits, L64

            Nick Boldt added a comment -

            Based on previous comment, I'm resolving this. If there's nothing left to verify, please close it.

            Nick Boldt added a comment - Based on previous comment, I'm resolving this. If there's nothing left to verify, please close it.

            now JBDS features can be installed by selecting JBoss Developer Studio from Abriged JBoss Developer Studio category. This feature would install only features included into JBDS without launcher.

            Names should be changed for product feature com.jboss.jbds.all w/ launcher and aggregation feature com.jboss.jbds.feature because now they are the same (see JBDS-2087) and it's confusing for inexperienced users.

            Denis Golovin (Inactive) added a comment - now JBDS features can be installed by selecting JBoss Developer Studio from Abriged JBoss Developer Studio category. This feature would install only features included into JBDS without launcher. Names should be changed for product feature com.jboss.jbds.all w/ launcher and aggregation feature com.jboss.jbds.feature because now they are the same (see JBDS-2087 ) and it's confusing for inexperienced users.

            fixed jvm arg initialization for com.jboss.jbds.feature installation using p2.inf

            Denis Golovin (Inactive) added a comment - fixed jvm arg initialization for com.jboss.jbds.feature installation using p2.inf

            It happens because you install root feature. It is composed of regular features and binary feature with launcher/ini files. Binary feature is generated out of .product file, so I didn't do so much work here just configured all parts of .product file.

            To adjust java options related to memory I can add them into .product file and they will be merged into jbdevstudio.ini file during update.

            To have installed only features without launcher/ini files you can try to install "JBoss Developer Studio" feature from uncategorized features like

            but then we have to figure out how force eclipse update -vmargs in eclipse.ini file. It is probably just a matter of addin p2.inf file along with feature.xml, but I never did that before.

            Denis Golovin (Inactive) added a comment - It happens because you install root feature. It is composed of regular features and binary feature with launcher/ini files. Binary feature is generated out of .product file, so I didn't do so much work here just configured all parts of .product file. To adjust java options related to memory I can add them into .product file and they will be merged into jbdevstudio.ini file during update. To have installed only features without launcher/ini files you can try to install "JBoss Developer Studio" feature from uncategorized features like but then we have to figure out how force eclipse update -vmargs in eclipse.ini file. It is probably just a matter of addin p2.inf file along with feature.xml, but I never did that before.

            Denis (or Snjezana if you reassign it any good ideas ?

            It's actually a bit wrong that when you install into plain eclipse it gets "transformed" into a full JBDS instead of "just" an eclipse with a managed feature/plugins set ?

            Max Andersen added a comment - Denis (or Snjezana if you reassign it any good ideas ? It's actually a bit wrong that when you install into plain eclipse it gets "transformed" into a full JBDS instead of "just" an eclipse with a managed feature/plugins set ?

            Nick Boldt added a comment -

            We can either close this or assign it to Denis/Sneja to see if they can come up w/ a p2.inf post-install setup step which would overwrite the user's existing config.ini with updated memory settings.

            @Max: what would you prefer?

            Nick Boldt added a comment - We can either close this or assign it to Denis/Sneja to see if they can come up w/ a p2.inf post-install setup step which would overwrite the user's existing config.ini with updated memory settings. @Max: what would you prefer?

            yes - I have to make sure I either restart with jbdevstudio command or update the eclipse.ini.

            Max Andersen added a comment - yes - I have to make sure I either restart with jbdevstudio command or update the eclipse.ini.

            Nick Boldt added a comment - - edited

            Eclipse 3.6.2 / Helios SR2 uses very little memory in its eclipse.ini:

            -Xms40m -Xmx384m

            JBDS 4.0.0, however, sets much more reasonable minimums:

            -Xms512m -Xmx1024m

            If you tweak your eclipse.ini file with these values, does it work, or still throw OOM?

            Nick Boldt added a comment - - edited Eclipse 3.6.2 / Helios SR2 uses very little memory in its eclipse.ini: -Xms40m -Xmx384m JBDS 4.0.0, however, sets much more reasonable minimums: -Xms512m -Xmx1024m If you tweak your eclipse.ini file with these values, does it work, or still throw OOM?

            Nick Boldt added a comment -

            It sounds like you're asking for post-install p2.inf instructions that say, if you're installing JBDS 4 from update site, make sure that .ini files and other meta are properly located on disk and those that should be removed/renamed/disabled are removed/renamed/disabled so as to avoid conflicts w/ default .ini settings.

            Perhaps this could be assigned to Sneja or Denis?

            Nick Boldt added a comment - It sounds like you're asking for post-install p2.inf instructions that say, if you're installing JBDS 4 from update site, make sure that .ini files and other meta are properly located on disk and those that should be removed/renamed/disabled are removed/renamed/disabled so as to avoid conflicts w/ default .ini settings. Perhaps this could be assigned to Sneja or Denis?

              nivologd@gmail.com Denis Golovin (Inactive)
              manderse@redhat.com Max Andersen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: