-
Bug
-
Resolution: Done
-
Major
-
JBossAS-3.2.6 Final
-
None
SourceForge Submitter: rodburgett .
The purpose of this patch is to improve the cleanup
operations of the deployers in org.jboss.deployment
package, specifically the Main and SAR deployers.
The primary change to the MainDeployer is to
supplement the shutdown method by nulling out
references and clearing containers.
Also, error messages in the stop(DeploymentInfo) and
destroy(DeploymentInfo) methods were updated to
indicate which method produced the messsage.
Finally in the MainDeployer, the init(DeploymentInfo)
method included a suspicious synchronized block. The
target code for synchronization adds an entry to the
deploymentMap field, but the subject of the
synchronized statement is a different field,
deploymentList. It is possible that this mismatch is
intentional, but it suggests to me a cut-n-paste error.
The SARDeployer patch file adds a stopService() method
to null out internal references that were initialized in
startService(). Prior to updating these references,
super.stopService() is called.