Uploaded image for project: 'Application Server 3  4  5 and 6'
  1. Application Server 3 4 5 and 6
  2. JBAS-5074

MarshalledInvocation constructor should copy over all invocation attributes

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • JBossAS-5.0.0.Beta4
    • JBossAS-5.0.0.Beta2
    • EJB2
    • None

      trunk and 4.2.x differ slightly when it comes to org.jboss.invocation.MarshalledInvocation class.

      in 4.2.x, MarshalledInvocation(Invocation invocation) constructor does:

      ...
      this.transient_payload = invocation.transient_payload;
      this.invocationContext = invocation.invocationContext;
      ...

      whereas in trunk, the transient payload is not copied over to the MarshalledInvocation.

      The discrepancy comes from:

      http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/branches/Branch_4_2/server/src/main/org/jboss/invocation/MarshalledInvocation.java?r1=38132&r2=41001

      as part of:

      "JBAS-2436 - Commiting Pluggable Serialization into JBAS 4.0" (http://jira.jboss.com/jira/browse/JBAS-2436)

      Brian:

      "The values should be copied. Without them the Invocation API contract cannot be properly met (e.g. Invocation.getInvocationContext(), Invocation.getTransientValue()).

      Maybe those methods are never called (except, I guess, now they are called in your tests ) but they are part of the API and properly supporting the API is worth the cost of a couple of assignment operations."

              rh-ee-galder Galder ZamarreƱo
              rh-ee-galder Galder ZamarreƱo
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: