Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-7556

Decoder2x.readOptionalParams should not call markReaderIndex()

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 9.0.0.Final
    • 9.0.0.Final
    • Server
    • None

      Decoder2x.readOptionalParams() calls buffer.markReaderIndex() after reading each parameter, but doesn't save the parameters anywhere. That means if the buffer doesn't contain all the parameters, the decode pass ends unsuccessfully, and the next decode pass doesn't see the parameters read by the previous pass.

      Higher-level methods like Decoder2x.readMaybeNamedFactory() also call readOptionalParams() without saving their own state first, meaning their state can be lost as well.

              dberinde@redhat.com Dan Berindei (Inactive)
              dberinde@redhat.com Dan Berindei (Inactive)
              Archiver:
              rhn-support-adongare Amol Dongare

                Created:
                Updated:
                Resolved:
                Archived: