Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-6925

Race condition in staggered gets

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Critical
    • 8.2.5.Final, 9.0.0.Beta1
    • 8.2.3.Final, 9.0.0.Alpha3
    • Core
    • None

    Description

      There's a race condition in CommandAwareRpcDispatcher, as we do staggered gets. When the RspList is prepared, and then in processCallsStaggered$lambda the Rsp is filled in - both of them can set is as received but later see that the other response was not received yet, because there's no memory barrieri n between the setValue/setException and checking wasReceived.

      The race above happens when two responses come but none of them is accepted by the filter, but there's a second one in JGroupsTransport when the first response is accepted but then comes another one. In JGroupsTransport.invokeRemotelyAsync in the lambda handling rspListFuture.thenApply we may see another thread concurrently modifying the rsps; e.g. in checkRsp you find out that the concurrently written response was received and it's not an exception according to flags, but the value will be null, so you return null while you can have valid response in the other Rsp.

      Attachments

        1. server.log.node1
          5.78 MB
        2. server.log.node2
          5.71 MB
        3. server.log.node3
          4.25 MB

        Issue Links

          Activity

            People

              rvansa1@redhat.com Radim Vansa (Inactive)
              rvansa1@redhat.com Radim Vansa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: