Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-5564

AsyncCacheWriter stop() and clear() should not wait for space in the modifications queue

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Major Major
    • 8.0.0.Beta1, 7.2.4.Final
    • None
    • None
    • None

      AsyncCacheWriter.clear() invalidates all enqueued changes rather than adding more changes to the queue. Thus, clear should not wait if the queue is full.

      AsyncCacheWriter.stop() should also take effect immediately (i.e. set the stopped flag without waiting if the queue is full).

            [ISPN-5564] AsyncCacheWriter stop() and clear() should not wait for space in the modifications queue

            RH Bugzilla Integration added a comment -

            Vojtech Juranek <vjuranek@redhat.com> changed the Status of bug 1235165 from ON_QA to VERIFIED

            RH Bugzilla Integration added a comment - Vojtech Juranek <vjuranek@redhat.com> changed the Status of bug 1235165 from ON_QA to VERIFIED

            RH Bugzilla Integration added a comment -

            Dave Stahl <dstahl@redhat.com> changed the Status of bug 1235165 from MODIFIED to ON_QA

            RH Bugzilla Integration added a comment - Dave Stahl <dstahl@redhat.com> changed the Status of bug 1235165 from MODIFIED to ON_QA

            RH Bugzilla Integration added a comment -

            Sebastian Łaskawiec <slaskawi@redhat.com> changed the Status of bug 1235165 from NEW to MODIFIED

            RH Bugzilla Integration added a comment - Sebastian Łaskawiec <slaskawi@redhat.com> changed the Status of bug 1235165 from NEW to MODIFIED

            Karsten Blees (Inactive) added a comment - - edited

            I'm wondering if this really matters for stop().

            It may save another empty State on shutdown. But it is indeed quite unlikely that the buffer is completely full after passivation. So for stop() its more a cosmetic change.

            Karsten Blees (Inactive) added a comment - - edited I'm wondering if this really matters for stop() . It may save another empty State on shutdown. But it is indeed quite unlikely that the buffer is completely full after passivation. So for stop() its more a cosmetic change.

            Dan Berindei (Inactive) added a comment -

            kblees The fix is now integrated, but I'm wondering if this really matters for stop(). The cache is shutting down, so it's not issuing any more modifications, and stop() must wait for the processors to empty the queue and process all the modifications anyway.

            Dan Berindei (Inactive) added a comment - kblees The fix is now integrated, but I'm wondering if this really matters for stop() . The cache is shutting down, so it's not issuing any more modifications, and stop() must wait for the processors to empty the queue and process all the modifications anyway.

              Unassigned Unassigned
              kblees Karsten Blees (Inactive)
              Archiver:
              rhn-support-adongare Amol Dongare

                Created:
                Updated:
                Resolved:
                Archived: