Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-487

Log byte arrays partially in Hot Rod client

    XMLWordPrintable

Details

    • Task
    • Resolution: Done
    • Minor
    • 4.1.0.CR2
    • None
    • Remote Protocols
    • None
    • Low

    Description

      In SerializationMarshaller I see this:

      if (log.isTraceEnabled())

      { log.trace("Unmarshalled bytes: " + Arrays.toString(bytes) + " and returning object: " + o); }

      Using Arrays.toString() is Ok for most cases but if the serialized version is too big, it'd be hard to read trace logs.

      Instead, you should prob use a similar method to the one used by the HotRod/Memcached or when lazy deserialization is used where I call o.i.u.Util.printArray. This methods prints the byte array partially, only the first 10 bytes I believe, and if -Dinfinispan.arrays.debug=true is passed, it then prints the full array.

      Attachments

        Activity

          People

            mircea.markus Mircea Markus (Inactive)
            rh-ee-galder Galder ZamarreƱo
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: