Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-3704

StateTransfer's PutKeyValueCommand may trigger remote get

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Critical Critical
    • 7.0.0.Alpha1
    • 6.0.0.Final
    • Core

      In TX mode with write skew check on, ST executing puts may trigger a remote get.
      The condition in TxDistributionInterceptor.handleTxWriteCommand should probably be switched from

      if (ctx.isOriginLocal() && !skipRemoteGet || command.isConditional() || shouldFetchRemoteValuesForWriteSkewCheck(ctx, command))
           remoteGetBeforeWrite(ctx, command, recipientGenerator);
      

      to

      if (!skipRemoteGet && (ctx.isOriginLocal() || command.isConditional() || shouldFetchRemoteValuesForWriteSkewCheck(ctx, command)))
           remoteGetBeforeWrite(ctx, command, recipientGenerator);
      

      EDIT:
      I have also registered a situation where the Prepare/Commit command was executed remotely from within the ST because the topology has changed during the remote get. This should be avoided as well.

              dberinde@redhat.com Dan Berindei (Inactive)
              rvansa1@redhat.com Radim Vansa (Inactive)
              Archiver:
              rhn-support-adongare Amol Dongare

                Created:
                Updated:
                Resolved:
                Archived: