Loading...

Type: Bug
Resolution: Done
Priority: Major
Fix Version/s: 9.4.24.Final, 13.0.6.Final, 11.0.15.Final, 12.1.12.Final, 14.0.0.Final
Affects Version/s: 10.1.8.Final, 9.4.23.Final, 11.0.11.Final, 12.1.7.Final, 13.0.2.Final
Component/s: Core, Expiration
Labels:
- downstream_dependency

Workaround Description:
Hide

Use putAsync instead of putAll, e.g.

Cache<Object, Object> cache = ...; Map<Object, Object> m = ...; int size = m.size(); CompletableFuture<?>[] putFutures = new CompletableFuture[size]; int i = 0; for (Map.Entry<Object, Object> e : m.entrySet()) { putFutures[i++] = cache.putAsync(e.getKey(), e.getValue()); } CompletableFuture.allOf(putFutures).get(timeout, TimeUnit.SECONDS);
Show
Use putAsync instead of putAll , e.g. Cache< Object , Object > cache = ...; Map< Object , Object > m = ...; int size = m.size(); CompletableFuture<?>[] putFutures = new CompletableFuture[size]; int i = 0; for (Map.Entry< Object , Object > e : m.entrySet()) { putFutures[i++] = cache.putAsync(e.getKey(), e.getValue()); } CompletableFuture.allOf(putFutures).get(timeout, TimeUnit.SECONDS);
Git Pull Request:
https://github.com/infinispan/infinispan/pull/9788, https://github.com/infinispan/infinispan/pull/9789, https://github.com/infinispan/infinispan/pull/9805, https://github.com/infinispan/infinispan/pull/9815, https://github.com/infinispan/infinispan/pull/9816, https://github.com/infinispan/infinispan/pull/9828

EntryWrappingInterceptor.visitPutMapCommand processes the potential expiration of keys in the input map in parallel, and wraps the entries in the context in the threads that processed the expiration response.

But NonTxInvocationContext is not thread-safe, as it uses a HashMap internally. When a PutMapCommand affects 2 or more entries can can both expire, and their keys map to the same HashMap bucket, one of the updates may be lost and the distribution interceptor will later fail with an IllegalStateException: Entry should be always wrapped!.

[org.infinispan.remoting.inboundhandler.NonTotalOrderPerCacheInboundInvocationHandler] (thread-623,ejb,agw17-253) ISPN000071: Caught exception when handling command SingleRpcCommand{cacheName='Cache', command=PutMapCommand{map={a=1, b=2, c=3, d=4}, flags=[IGNORE_RETURN_VALUES], metadata=EmbeddedExpirableMetadata{lifespan=1800000, maxIdle=1800000, version=null}, isForwarded=true}}: java.lang.IllegalStateException: Entry should be always wrapped!
	at org.infinispan.interceptors.distribution.BaseDistributionInterceptor.getKeysByOwner(BaseDistributionInterceptor.java:598)
	at org.infinispan.interceptors.distribution.BaseDistributionInterceptor.doRemoteGetMany(BaseDistributionInterceptor.java:364)
	at org.infinispan.interceptors.distribution.BaseDistributionInterceptor.remoteGetMany(BaseDistributionInterceptor.java:357)
	at org.infinispan.interceptors.distribution.NonTxDistributionInterceptor.handleRemoteReadWriteManyCommand(NonTxDistributionInterceptor.java:419)
	at org.infinispan.interceptors.distribution.NonTxDistributionInterceptor.handleReadWriteManyCommand(NonTxDistributionInterceptor.java:306)
	at org.infinispan.interceptors.distribution.NonTxDistributionInterceptor.visitPutMapCommand(NonTxDistributionInterceptor.java:146)
	at org.infinispan.commands.write.PutMapCommand.acceptVisitor(PutMapCommand.java:79)
	at org.infinispan.interceptors.BaseAsyncInterceptor.invokeNext(BaseAsyncInterceptor.java:55)
	at org.infinispan.interceptors.BaseAsyncInterceptor.lambda$new$0(BaseAsyncInterceptor.java:23)
	at org.infinispan.interceptors.InvocationSuccessFunction.apply(InvocationSuccessFunction.java:25)
	at org.infinispan.interceptors.impl.QueueAsyncInvocationStage.invokeQueuedHandlers(QueueAsyncInvocationStage.java:118)
	at org.infinispan.interceptors.impl.QueueAsyncInvocationStage.accept(QueueAsyncInvocationStage.java:81)
	at org.infinispan.interceptors.impl.QueueAsyncInvocationStage.accept(QueueAsyncInvocationStage.java:30)
	at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) [rt.jar:1.8.0_212]
	at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) [rt.jar:1.8.0_212]
	at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) [rt.jar:1.8.0_212]
	at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) [rt.jar:1.8.0_212]
	at org.infinispan.util.concurrent.CompletionStages$AbstractAggregateCompletionStage.complete(CompletionStages.java:288)
	at org.infinispan.util.concurrent.CompletionStages$AbstractAggregateCompletionStage.accept(CompletionStages.java:256)
	at org.infinispan.util.concurrent.CompletionStages$AbstractAggregateCompletionStage.accept(CompletionStages.java:240)
	at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) [rt.jar:1.8.0_212]
	at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) [rt.jar:1.8.0_212]
	at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) [rt.jar:1.8.0_212]
	at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) [rt.jar:1.8.0_212]
	at org.infinispan.interceptors.impl.QueueAsyncInvocationStage.invokeQueuedHandlers(QueueAsyncInvocationStage.java:106)
	at org.infinispan.interceptors.impl.QueueAsyncInvocationStage.accept(QueueAsyncInvocationStage.java:81)
	at org.infinispan.interceptors.impl.QueueAsyncInvocationStage.accept(QueueAsyncInvocationStage.java:30)
	at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) [rt.jar:1.8.0_212]
	at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) [rt.jar:1.8.0_212]
	at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) [rt.jar:1.8.0_212]
	at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962) [rt.jar:1.8.0_212]
	at org.infinispan.remoting.transport.AbstractRequest.complete(AbstractRequest.java:67)
	at org.infinispan.remoting.transport.impl.SingleTargetRequest.receiveResponse(SingleTargetRequest.java:57)

causes

JBEAP-23095 (8.0.z) Data race in EntryWrappingInterceptor handling expired entries

Verified

is cloned by

JBEAP-23085 (7.4.z) ISPN-13549 - Data race in EntryWrappingInterceptor handling expired entries

Verified

JDG-5028 Data race in EntryWrappingInterceptor handling expired entries

Closed

is incorporated by

WFLY-15939 Upgrade Infinispan to 13.0.6.Final

Closed

is related to

ISPN-7889 BaseDistributionInterceptor.remoteGet may cause concurrency issues

Closed

relates to

ISPN-13619 Deadlock when putAll writes to expired entries in a scattered cache

To Do

ISPN-13618 Deadlock when putAll writes to expired entries with optimistic locking

In Progress

(2 relates to)

Details

Description

Attachments

Issue Links

Activity

People

Dates