2:25:00 PM galderz: mmarkus: hi
2:25:26 PM mmarkus: hi galderz
2:26:11 PM galderz: hey mmarkus, i was wondering if the validation in TransactionFactory.init would be better suited for ConfigurationValidatingVisitor ?
2:26:30 PM galderz: i mean, the validation about the incompatible configuration options
2:28:49 PM mmarkus: galderz: which validation exactly? there's no validation in TransactionFactory.init ..
2:33:51 PM galderz: if (txFactoryEnum == null) { ....
2:34:01 PM galderz: Unsupported combination (dldEnabled, recoveryEnabled, xa) = (%s, %s, %s)
2:34:14 PM galderz: that's validation of the configuration afact
2:34:28 PM galderz: boolean dldEnabled = configuration.isEnableDeadlockDetection();
boolean recoveryEnabled = configuration.isTransactionRecoveryEnabled();
boolean xa = !configuration.isUseSynchronizationForTransactions();

2:37:58 PM mmarkus: galderz: yes, good point it should move to ConfigurationValidatingVisitor