Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-10150

InterceptorDefinesAllReadsCheck and InterceptorDefinesAllReadWritesCheck should report ERROR if the implementation was used in Production code

    XMLWordPrintable

Details

    • Task
    • Status: New (View Workflow)
    • Minor
    • Resolution: Unresolved
    • 9.4.12.Final
    • None
    • None
    • None

    Description

      [INFO] Starting audit...
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/interceptors/impl/ScatteredCacheWriterInterceptor.java:76:1: Interceptor defines methods [visitGetCacheEntryCommand, visitGetKeyValueCommand, visitGetAllCommand] but does not define [visitReadOnlyKeyCommand, visitReadOnlyManyCommand] [not required for tests] [InterceptorDefinesAllReads]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/interceptors/impl/CacheLoaderInterceptor.java:99:1: Interceptor defines methods [visitReadWriteKeyCommand, visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitPutKeyValueCommand, visitRemoveCommand, visitReadWriteManyEntriesCommand, visitReplaceCommand] but does not define [visitPutMapCommand] [not required for tests] [InterceptorDefinesAllReadWrites]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/interceptors/impl/IsMarshallableInterceptor.java:32:1: Interceptor defines methods [visitReadWriteKeyCommand, visitPutKeyValueCommand, visitRemoveCommand, visitPutMapCommand, visitReplaceCommand] but does not define [visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitReadWriteManyEntriesCommand] [not required for tests] [InterceptorDefinesAllReadWrites]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/interceptors/impl/BaseStateTransferInterceptor.java:343:4: Interceptor defines methods [visitGetCacheEntryCommand, visitGetKeyValueCommand, visitReadOnlyKeyCommand] but does not define [visitGetAllCommand, visitReadOnlyManyCommand] [not required for tests] [InterceptorDefinesAllReads]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/interceptors/impl/BatchingInterceptor.java:26:1: Interceptor defines methods [visitPutKeyValueCommand] but does not define [visitReadWriteKeyCommand, visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitRemoveCommand, visitPutMapCommand, visitReadWriteManyEntriesCommand, visitReplaceCommand] [not required for tests] [InterceptorDefinesAllReadWrites]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/interceptors/impl/DistCacheWriterInterceptor.java:38:1: Interceptor defines methods [visitPutKeyValueCommand, visitRemoveCommand, visitPutMapCommand, visitReplaceCommand] but does not define [visitReadWriteKeyCommand, visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitReadWriteManyEntriesCommand] [not required for tests] [InterceptorDefinesAllReadWrites]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/interceptors/impl/InvalidationInterceptor.java:62:1: Interceptor defines methods [visitPutKeyValueCommand, visitRemoveCommand, visitPutMapCommand, visitReplaceCommand] but does not define [visitReadWriteKeyCommand, visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitReadWriteManyEntriesCommand] [not required for tests] [InterceptorDefinesAllReadWrites]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/interceptors/impl/InvalidationInterceptor.java:259:4: Interceptor defines methods [visitPutKeyValueCommand, visitRemoveCommand, visitPutMapCommand] but does not define [visitReadWriteKeyCommand, visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitReadWriteManyEntriesCommand, visitReplaceCommand] [not required for tests] [InterceptorDefinesAllReadWrites]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/interceptors/impl/VersionInterceptor.java:16:1: Interceptor defines methods [visitReplaceCommand] but does not define [visitReadWriteKeyCommand, visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitPutKeyValueCommand, visitRemoveCommand, visitPutMapCommand, visitReadWriteManyEntriesCommand] [not required for tests] [InterceptorDefinesAllReadWrites]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/interceptors/distribution/L1TxInterceptor.java:24:1: Interceptor defines methods [visitPutKeyValueCommand, visitRemoveCommand, visitPutMapCommand, visitReplaceCommand] but does not define [visitReadWriteKeyCommand, visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitReadWriteManyEntriesCommand] [not required for tests] [InterceptorDefinesAllReadWrites]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/interceptors/distribution/TxDistributionInterceptor.java:85:1: Interceptor defines methods [visitReadOnlyManyCommand] but does not define [visitGetCacheEntryCommand, visitGetKeyValueCommand, visitGetAllCommand, visitReadOnlyKeyCommand] [not required for tests] [InterceptorDefinesAllReads]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/interceptors/distribution/L1NonTxInterceptor.java:62:1: Interceptor defines methods [visitGetCacheEntryCommand, visitGetKeyValueCommand] but does not define [visitGetAllCommand, visitReadOnlyKeyCommand, visitReadOnlyManyCommand] [not required for tests] [InterceptorDefinesAllReads]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/partitionhandling/impl/PartitionHandlingInterceptor.java:39:1: Interceptor defines methods [visitGetCacheEntryCommand, visitGetKeyValueCommand, visitGetAllCommand] but does not define [visitReadOnlyKeyCommand, visitReadOnlyManyCommand] [not required for tests] [InterceptorDefinesAllReads]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/partitionhandling/impl/PartitionHandlingInterceptor.java:39:1: Interceptor defines methods [visitReadWriteKeyCommand, visitPutKeyValueCommand, visitRemoveCommand, visitPutMapCommand, visitReplaceCommand] but does not define [visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitReadWriteManyEntriesCommand] [not required for tests] [InterceptorDefinesAllReadWrites]
      [WARN] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/main/java/org/infinispan/xsite/BaseBackupReceiver.java:87:4: Interceptor defines methods [visitPutKeyValueCommand, visitRemoveCommand] but does not define [visitReadWriteKeyCommand, visitReadWriteManyCommand, visitReadWriteKeyValueCommand, visitPutMapCommand, visitReadWriteManyEntriesCommand, visitReplaceCommand] [not required for tests] [InterceptorDefinesAllReadWrites]
      [ERROR] /Users/dlovison/Documents/GitHub/infinispan/infinispan/core/src/test/resources/infinispan-features.properties:1: Missing new line at the end of file [RegexpMultiline]
      Audit done.
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            dlovison@redhat.com Diego Lovison
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: