https://github.com/openshift/cluster-image-registry-operator/pull/930 introduced the azureclient package to abstract interaction with the azure api.
However, the work there was focused on private endpoint creation. To keep the scope of the changes as small as possible, storage account creation code was not moved to the azureclient package.
NOTE: azure stack hub does not support the new sdk, so we need to continue using the old sdk to create storage accounts, at least for azure stack hub.
ACCEPTANCE CRITERIA
- All code that directly interacts with the azure sdk is contained within the azureclient package
- Everything continues to work on Azure public cloud, Azure stack hub and Azure government