Uploaded image for project: 'ProtoStream'
  1. ProtoStream
  2. IPROTO-130

Inefficient ProtobufUtil.fromWrappedByteArray(ImmutableSerializationContext ctx, byte[] bytes)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Major Major
    • 4.2.6.Final, 4.3.3.Final
    • 4.2.5.Final, 4.3.2.Final
    • None
    • None

      The implementation uses a ByteArrayInputStream that wraps the byte[], and then creates a CodedInputStream around it and this copies the input data to its own buffer. This should have been made more efficiently by building a CodedInputStream directly around the byte[] (which internally uses CodedInputStream.ArrayDecoder and doesn't need a buffer copy).

            anistor Adrian Nistor (Inactive)
            anistor Adrian Nistor (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: