Uploaded image for project: 'Insights Experiences'
  1. Insights Experiences
  2. HMS-9880

[BUG] `process.env.IS_ON_PREMISE` might not be normalised correctly

    • Icon: Task Task
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • Image Builder
    • None

      From a PR review [comment](https://github.com/osbuild/image-builder-frontend/pull/3871#discussion_r2580386187):

      The condition uses process.env.IS_ON_PREMISE directly without normalization. When webpack's DefinePlugin injects the string 'false', the expression !process.env.IS_ON_PREMISE evaluates to false (since !'false' is false), causing the OpenSourceBadge to not render when it should.

      We should probably look into this a bit further and maybe normalise this in all places. This change was out of the scope of the PR though.

      GitHub Issue: https://github.com/osbuild/image-builder-frontend/issues/3916

              gzuccare@redhat.com Gianluca Zuccarelli
              imagebuilder-bot Image-Builder Bot
              None
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: