Uploaded image for project: 'Insights Experiences'
  1. Insights Experiences
  2. HMS-9501

CloudAPI: fix `/compose/{id}/manifests` endpoint behavior on manifest generation errors

    • Icon: Task Task
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • Image Builder
    • None

      While porting https://github.com/osbuild/images/pull/1907 to osbuild-composer, I ran into the problem that the CloudAPI endpoint for compose manifests was not checking manifest generation job results and would return a 'nil' value instead of an error if the manifest generation failed.

      Moreover, the mock data used by unit tests for depsolved packages was not complete and was lacking basic properties, such as the remote location URL, which is needed to generate an osbuild manifest.

      This PR addresses the issues mentioned above, it also adds a unit test for compose manifests Cloud API endpoint and improves unit tests where failure debugging was previously unnecessarily complicated.

      /jira-epic HMS-8910

              thozza@redhat.com Tomas Hozza
              imagebuilder-bot Image-Builder Bot
              None
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: