Uploaded image for project: 'Insights Experiences'
  1. Insights Experiences
  2. HMS-3554

The activation key on the Review step still shows the "Selected activation key" at the review step

    • None

      The activation key on the Review step still shows the "Selected activation key" heading. Similar to the ReleaseLifecycle we might want to solve this one in a separate PR.

      Thinking about this I can see two approaches to this:

      First approach is we create a description list with the needed values directly in this file. That would mean copying a long blob of <TextContent> code over from ActivationKeyInformation which would mean a lot of duplicity. Not ideal, would get rid of the FormGroup label.

      Second option would be that we create a separate PR and do the decisions directly in the ActivationKeyInformation component (I would much prefer this solution). We can figure out on which step we currently are in the Wizard: https://www.patternfly.org/components/wizard#get-current-step and based on this information we can render / not render the FormGroup. So it would go roughly like this:

      • in the ActivationKeyInformation
      • get currentStep of the Wizard
      • if currentStep === 'registration' render FormGroup else render just TextContent

              ksimicko Klara Simickova
              mgold@redhat.com Michal Gold
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: