Uploaded image for project: 'Insights Experiences'
  1. Insights Experiences
  2. HMS-1829

Return provider type for GET sources instead of type_id and uid

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • None
    • None
    • Provisioning
    • None
    • EnVision Sprint 29, EnVision Sprint 42
    • 3
    • None

      We should only expose minimum amount of information, currently we return this:

      type SourceResponse struct {
      	ID           string `json:"id" yaml:"id"`
      	Name         string `json:"name,omitempty" yaml:"name"`
      	SourceTypeID string `json:"source_type_id" yaml:"source_type_id"`
      	Uid          string `json:"uid" yaml:"uid"`
      }
      

      These are internal information from sources which we should not expose at all (SourceTypeID and Uid). Let’s remove these fields ideally before code unfreeze and API 1.0.0 announcement.

      Instead, we should expose our ProviderType.String() value which we can map as needed.

              oezr@redhat.com Ondrej Ezr
              rhn-engineering-lzapletal Lukáš Zapletal
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: