-
Bug
-
Resolution: Done
-
Major
-
None
-
None
-
None
-
EnVision Sprint 28, EnVision Sprint 29, EnVision Sprint 30
-
None
We currently do not check for nil for AWS Public IP. Public IPs are precious resource and customers have limited amount of them available, there are also some hard limits per account. When you launch many instances (performance team launched 30 and 100) AWS starts to launch instances without any public IPs, thus the value is nil. This leads to nil pointer error.
https://glitchtip.devshift.net/insights/issues/632696?project=29
Let’s fix that. Also check Azure and GCP while on this, it might be the case for these as well.
I suggest to create helper function ptr.ToOrEmpty which will dereference pointer or in case its nil then it will create empty type (empty string, zero number) via "new" keyword and Go generics. Looks like this might be useful, but this is just an idea feel free to skip this.