OCP/Telco Definition of Done
Epic Template descriptions and documentation.

<--- Cut-n-Paste the entire contents of this description into your new Epic --->

Epic Goal

• Provide hive custom resource support for specification of user-defined network tags for GCP nodes.

Existing OCP support

The OCP deployer supports custom network tags through the AdditionalNetworkTags field of the GcpMachineType spec:

  controlPlane:
    name: master
    platform:
      gcp:
        tags:
          - control-plane-tag
          - shared-tag

  compute:
  - name: worker
    platform:
      gcp:
        tags:
          - worker-tag
          - shared-tag 

Day-2 operations on nodes are handled by the machine-api-operator. This operator supports the creation and modification of network tags on machinesets:

  apiVersion: machine.openshift.io/v1beta1
  kind: MachineSet
  spec:
    template:
      spec:
        providerSpec:
            # Custom network tags - add your tags here
            tags:
              - <cluster-id>-worker
              - custom-firewall-tag
              - web-servers
              - allow-http-https 

Why is this important?

• Support is needed for the delivery of the parent OSD-GCP feature.

Scenarios

1. User creates a cluster with user-defined network tags for control-plane and worker nodes.
2. User creates a day-2 machine pool with user-defined network tags.
3. Network tag configuration is immutable. The user may not change network tags after the machine pool has been created. The user would instead create a new machine pool with the desired values, then delete the old machine pool.

Acceptance Criteria

• CI - MUST be running successfully with tests automated
• Release Technical Enablement - Provide necessary release enablement details and documents.
• ...

Dependencies (internal and external)

1. ...

Previous Work (Optional):

1. …

Open questions::

1. …

Done Checklist

• CI - CI is running, tests are automated and merged.
• Release Enablement <link to Feature Enablement Presentation>
• DEV - Upstream code and tests merged: <link to meaningful PR or GitHub Issue>
• DEV - Upstream documentation merged: <link to meaningful PR or GitHub Issue>
• DEV - Downstream build attached to advisory: <link to errata>
• QE - Test plans in Polarion: <link or reference to Polarion>
• QE - Automated tests merged: <link or reference to automated tests>
• DOC - Downstream documentation merged: <link to meaningful PR>