-
Story
-
Resolution: Unresolved
-
Undefined
-
None
-
None
-
None
-
None
-
False
-
-
False
-
None
-
None
-
None
-
None
-
None
cf. comment.
Currently the PrivateLink code contains logic to Update() status conditions with a blind retry on 409 Conflict. This is not correct reconcile idempotence: theoretically the operation causing the conflict could have changed the configuration that prompted the condition update, rendering that update incorrect.
The usual pattern for this is to let the error from the status update bubble up and fail the reconcile, causing a requeue, whereupon the/a subsequent reconcile would fully re-evaluate the need for the status update and reapply it if/as appropriate.
Don't forget to update unit tests to cover cases currently missed because mocking a failure through a backoff retry is Hardâ„¢.
Also applies to updatePrivateServiceConnectStatus.
- relates to
-
HIVE-2525 Add privatelink_controller unit test
-
- Closed
-
- links to