Uploaded image for project: 'OpenShift Hive'
  1. OpenShift Hive
  2. HIVE-2635

Earlier validation of controller poll intervals

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • openshift-4.18
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • None
    • None
    • None

      Today if you enter an invalid (i.e. unparseable as a Duration) value for hiveConfig.spec.

      • syncSetReapplyInterval
      • machinePoolPollInterval
      • clusterVersionPollInterval

      ...the respective controller pods will crash.

      I feel like we can do better – validate earlier.

      First, let's try adding pattern validation to these fields, like we have for e.g. ClusterDeployment.Spec.HibernateAfter.

      If for some reason this doesn't work, we should add prevalidation (simply ParseDuration() and check for non-nill error) to hive-operator and fail there instead.

              efried.openshift Eric Fried
              efried.openshift Eric Fried
              None
              None
              Jianping Shu Jianping Shu
              None
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: