Uploaded image for project: 'OpenShift Hive'
  1. OpenShift Hive
  2. HIVE-2626

Fix (build-machinery-go path to) use of controller-gen v0.16

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Critical Critical
    • openshift-4.18
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • None
    • None
    • None

      In HIVE-2616, while upgrading hive to use k8s 1.31, it was necessary to pull in controller-gen v0.16 (we ended up using v0.16.1). Prior to that PR we were getting our controller-gen binary via build-machinery-go, which grabbed it from the openshift fork of the controller-tools repo. But that fork hasn't been updated in a while, and specifically doesn't have the code or release or binaries for v0.16; so that PR bypasses BMG entirely and grabs the controller-gen binary from the upstream controller-tools repo. However, it does it in a kind of dumb and messy way.

      We need to decide whether we want to continue using build-machinery-go for controller-gen. If so, we must:

      If not, we should clean up the Makefile piece of https://github.com/openshift/hive/pull/2477 to be more

      • cache-y: right now it always pulls the controller-gen binary
      • file system pathing agnostic: right now it assumes the above installs at $GOPATH/bin (because I think we can't rely on $GOBIN to be set)

              efried.openshift Eric Fried
              efried.openshift Eric Fried
              None
              Mingxia Huang
              Jianping Shu Jianping Shu
              None
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: